<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24852">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hodec1: use same automatic FULL/SUBSET choice as in hodec2<br><br>So far handover decision 1 uses the FULL or SUBSET TDMA measurements<br>across all measurement reports, depending on whether the last<br>measurement report indicates that DTX is in use or not.<br><br>Handover decision 2 since recently uses TDMA_MEAS_SET_AUTO to choose for<br>each individual measurement report whether to use the FULL or the SUBSET<br>value, depending on each single report's DTX use flag.<br><br>Also switch handover decision 1 to heed every single report's DTX flag,<br>by simply using TDMA_MEAS_SET_AUTO, replacing the current decision.<br><br>Change-Id: Iebe980254b8c4a53ef9e7d720e417dc67077eff7<br>---<br>M src/osmo-bsc/handover_decision.c<br>1 file changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision.c b/src/osmo-bsc/handover_decision.c</span><br><span>index 220fa1c..2fb466c 100644</span><br><span>--- a/src/osmo-bsc/handover_decision.c</span><br><span>+++ b/src/osmo-bsc/handover_decision.c</span><br><span>@@ -214,7 +214,6 @@</span><br><span> static void on_measurement_report(struct gsm_meas_rep *mr)</span><br><span> {</span><br><span>    struct gsm_bts *bts = mr->lchan->ts->trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-      enum tdma_meas_set meas_set;</span><br><span>         int av_rxlev;</span><br><span>        unsigned int pwr_interval;</span><br><span> </span><br><span>@@ -231,18 +230,16 @@</span><br><span>               return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   meas_set = (mr->flags & MEAS_REP_F_DL_DTX) ? TDMA_MEAS_SET_SUB : TDMA_MEAS_SET_FULL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  /* parse actual neighbor cell info */</span><br><span>        if (mr->num_cell > 0 && mr->num_cell < 7)</span><br><span>                process_meas_neigh(mr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     av_rxlev = get_meas_rep_avg(mr->lchan, TDMA_MEAS_FIELD_RXLEV, TDMA_MEAS_DIR_DL, meas_set,</span><br><span style="color: hsl(120, 100%, 40%);">+  av_rxlev = get_meas_rep_avg(mr->lchan, TDMA_MEAS_FIELD_RXLEV, TDMA_MEAS_DIR_DL, TDMA_MEAS_SET_AUTO,</span><br><span>                                   ho_get_hodec1_rxlev_avg_win(bts->ho));</span><br><span> </span><br><span>    /* Interference HO */</span><br><span>        if (rxlev2dbm(av_rxlev) > -85 &&</span><br><span style="color: hsl(0, 100%, 40%);">-         meas_rep_n_out_of_m_be(mr->lchan, TDMA_MEAS_FIELD_RXQUAL, TDMA_MEAS_DIR_DL, meas_set, 3, 4, 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          meas_rep_n_out_of_m_be(mr->lchan, TDMA_MEAS_FIELD_RXQUAL, TDMA_MEAS_DIR_DL, TDMA_MEAS_SET_AUTO, 3, 4, 5)) {</span><br><span>           LOGPC(DHO, LOGL_INFO, "HO cause: Interference HO av_rxlev=%d dBm\n",</span><br><span>                     rxlev2dbm(av_rxlev));</span><br><span>          attempt_handover(mr);</span><br><span>@@ -250,7 +247,7 @@</span><br><span>  }</span><br><span> </span><br><span>        /* Bad Quality */</span><br><span style="color: hsl(0, 100%, 40%);">-       if (meas_rep_n_out_of_m_be(mr->lchan, TDMA_MEAS_FIELD_RXQUAL, TDMA_MEAS_DIR_DL, meas_set, 3, 4, 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (meas_rep_n_out_of_m_be(mr->lchan, TDMA_MEAS_FIELD_RXQUAL, TDMA_MEAS_DIR_DL, TDMA_MEAS_SET_AUTO, 3, 4, 5)) {</span><br><span>           LOGPC(DHO, LOGL_INFO, "HO cause: Bad Quality av_rxlev=%d dBm\n", rxlev2dbm(av_rxlev));</span><br><span>             attempt_handover(mr);</span><br><span>                return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24852">change 24852</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24852"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iebe980254b8c4a53ef9e7d720e417dc67077eff7 </div>
<div style="display:none"> Gerrit-Change-Number: 24852 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>