<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24882">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan: call reset() upon alloc<br><br>call lchan_reset() after allocation, to make sure that lchan->* fields<br>that have a nonzero default value get initialized properly.<br><br>In particular, a future patch adds interference measurements, and an<br>lchan that never received any Resource Indication info should always<br>indicate that there are no measurements (a nonzero constant).<br><br>Change-Id: I700a969f5b11c21dacda9a7cad00c943dce554b3<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/24882/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 6350481..47a8f9e 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -433,6 +433,8 @@</span><br><span>  lchan_rtp_fsm_init();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void lchan_reset(struct gsm_lchan *lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void lchan_fsm_alloc(struct gsm_lchan *lchan)</span><br><span> {</span><br><span>    OSMO_ASSERT(lchan->ts);</span><br><span>@@ -444,6 +446,7 @@</span><br><span>     lchan->fi->priv = lchan;</span><br><span>       lchan_fsm_update_id(lchan);</span><br><span>  LOGPFSML(lchan->fi, LOGL_DEBUG, "new lchan\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  lchan_reset(lchan);</span><br><span> }</span><br><span> </span><br><span> /* Clear volatile state of the lchan. Clear all except</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24882">change 24882</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24882"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I700a969f5b11c21dacda9a7cad00c943dce554b3 </div>
<div style="display:none"> Gerrit-Change-Number: 24882 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>