<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/24869">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: checkpatch.pl: fix && complaints<br><br>Don't complain with:<br>    ERROR:SPACING: space prohibited after that '&&' (ctx:ExW)<br>in code similar to:<br>        if (conn->conn->mode != MGCP_CONN_LOOPBACK<br>          && conn->conn->mode != MGCP_CONN_RECV_ONLY<br>      && !mgcp_rtp_end_remote_addr_available(&conn->end)) {<br><br>The check was supposed to complain about spaces if the && is used as<br>unary operator (to get the address of a goto label). But it's clearly<br>producing false positives in the Osmocom context with use as non-unary<br>operator, so remove this check.<br><br>Related: OS#5087<br>Related: https://github.com/torvalds/linux/commit/0d413866c7df63794790518e3fd5890969c206ad<br>Change-Id: I7ce79e6b291b3a3dab6587a589eeef0a0bc53de9<br>---<br>M lint/checkpatch/checkpatch.pl<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/24869/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl</span><br><span>index dc56812..ad99e0c 100755</span><br><span>--- a/lint/checkpatch/checkpatch.pl</span><br><span>+++ b/lint/checkpatch/checkpatch.pl</span><br><span>@@ -5072,7 +5072,7 @@</span><br><span>                             # unary operator, or a cast</span><br><span>                          } elsif ($op eq '!' || $op eq '~' ||</span><br><span>                                          $opv eq '*U' || $opv eq '-U' ||</span><br><span style="color: hsl(0, 100%, 40%);">-                                         $opv eq '&U' || $opv eq '&&U') {</span><br><span style="color: hsl(120, 100%, 40%);">+                                  $opv eq '&U') {  # Osmocom specific: &&U removed</span><br><span>                                        if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {</span><br><span>                                                if (ERROR("SPACING",</span><br><span>                                                         "space required before that '$op' $at\n" . $hereptr)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/24869">change 24869</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/24869"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7ce79e6b291b3a3dab6587a589eeef0a0bc53de9 </div>
<div style="display:none"> Gerrit-Change-Number: 24869 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>