<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24881">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix api doc of osmo_identifier_sanitize_buf()<br><br>The implementation cleary replaces sep_chars instead of keeping them.<br>Adjust the doc to clarify that.<br><br>It seems to me that the intention was to *allow* sep_chars instead of<br>replacing them, especially when looking at sep_chars of<br>osmo_separated_identifiers_valid(). But we're stuck with that now.<br><br>Change-Id: Ia842a7eeb46b49ee364be55c1194e463ebcaf392<br>---<br>M src/utils.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/24881/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/utils.c b/src/utils.c</span><br><span>index f5896c4..721c34a 100644</span><br><span>--- a/src/utils.c</span><br><span>+++ b/src/utils.c</span><br><span>@@ -687,7 +687,7 @@</span><br><span>  * To guarantee passing osmo_separated_identifiers_valid(), replace_with must not itself be an illegal character. If in</span><br><span>  * doubt, use '-'.</span><br><span>  * \param[inout] str  Identifier to sanitize, must be nul terminated and in a writable buffer.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] sep_chars  Additional characters that are allowed besides osmo_identifier_illegal_chars.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] sep_chars  Additional characters that are to be replaced besides osmo_identifier_illegal_chars.</span><br><span>  * \param[in] replace_with  Replace any illegal characters with this character.</span><br><span>  */</span><br><span> void osmo_identifier_sanitize_buf(char *str, const char *sep_chars, char replace_with)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24881">change 24881</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24881"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia842a7eeb46b49ee364be55c1194e463ebcaf392 </div>
<div style="display:none"> Gerrit-Change-Number: 24881 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>