<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24855">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Do not transmit dummy RLC/MAC blocks on non-BCCH carriers<br><br>Transmission of dummy RLC/MAC blocks over the Um-interface can be avoided<br>on non-BCCH carriers for the purpose of energy saving.  The idea is simple:<br>if a PDCH timeslot has no Uplink nor Downlink TBFs allocated, then (most<br>likely) nobody is listening to it.  This is indicated by the PCU using the<br>least significant bit of a new field 'flags' in PCUIF DATA.req messages.<br><br>Change-Id: I2bf5271c4f1eaf5a975129f73091eb51cee50e57<br>Related: SYS#4919, OS#4772<br>---<br>M include/osmo-bts/pcuif_proto.h<br>M src/common/pcu_sock.c<br>2 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/24855/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h</span><br><span>index 3e6f651..c3605ec 100644</span><br><span>--- a/include/osmo-bts/pcuif_proto.h</span><br><span>+++ b/include/osmo-bts/pcuif_proto.h</span><br><span>@@ -68,6 +68,9 @@</span><br><span>        char            text[TXT_MAX_LEN]; /* Text to be transmitted to BTS */</span><br><span> } __attribute__ ((packed));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Indicates that the PDU contains a dummy RLC/MAC block */</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCU_IF_DATA_F_DUMMY             (1 << 0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct gsm_pcu_if_data {</span><br><span>         uint8_t         sapi;</span><br><span>        uint8_t         len;</span><br><span>@@ -81,6 +84,7 @@</span><br><span>     uint16_t        ber10k;         /* !< \brief BER in units of 0.01% */</span><br><span>     int16_t         ta_offs_qbits;  /* !< \brief Burst TA Offset in quarter bits */</span><br><span>   int16_t         lqual_cb;       /* !< \brief Link quality in centiBel */</span><br><span style="color: hsl(120, 100%, 40%);">+   uint8_t         flags;          /* !< \brief See See PCU_IF_DATA_F_* above */</span><br><span> } __attribute__ ((packed));</span><br><span> </span><br><span> /* data confirmation with direct tlli (instead of raw mac block with tlli) */</span><br><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 41a5ffc..32a572a 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -690,6 +690,11 @@</span><br><span>                 break;</span><br><span>       case PCU_IF_SAPI_PDTCH:</span><br><span>      case PCU_IF_SAPI_PTCCH:</span><br><span style="color: hsl(120, 100%, 40%);">+               /* Energy saving (OS#4772): do not transmit dummy RLC/MAC blocks on non-BCCH</span><br><span style="color: hsl(120, 100%, 40%);">+           * carriers if the PCU indicates that no TBFs are active at the moment. */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (data_req->flags & PCU_IF_DATA_F_DUMMY)</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (data_req->trx_nr > 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                               return 0;</span><br><span>            trx = gsm_bts_trx_num(bts, data_req->trx_nr);</span><br><span>             if (!trx) {</span><br><span>                  LOGP(DPCU, LOGL_ERROR, "Received PCU data request with "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24855">change 24855</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24855"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2bf5271c4f1eaf5a975129f73091eb51cee50e57 </div>
<div style="display:none"> Gerrit-Change-Number: 24855 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>