<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24863">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fail rx MDCX sendrecv with invalid remote addr<br><br>use the recently new available API to check both remote address and<br>port, instead of only the port.<br>It doesn't make sense to configure a conn as sendrecv if we have no IP<br>address to send stuff to, similar to what was already being checked with<br>the port.<br><br>Change-Id: I6ce8cf52930d423d3db8c27251be8350a26a4ede<br>---<br>M src/libosmo-mgcp/mgcp_protocol.c<br>M tests/mgcp/mgcp_test.c<br>M tests/mgcp/mgcp_test.ok<br>3 files changed, 93 insertions(+), 45 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/63/24863/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c</span><br><span>index c71a3ba..b716cf3 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_protocol.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_protocol.c</span><br><span>@@ -1149,7 +1149,7 @@</span><br><span> /* check connection mode setting */</span><br><span> if (conn->conn->mode != MGCP_CONN_LOOPBACK</span><br><span> && conn->conn->mode != MGCP_CONN_RECV_ONLY</span><br><span style="color: hsl(0, 100%, 40%);">- && conn->end.rtp_port == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ && !mgcp_rtp_end_remote_addr_available(&conn->end)) {</span><br><span> LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,</span><br><span> "MDCX: selected connection mode type requires an opposite end!\n");</span><br><span> error_code = 527;</span><br><span>diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c</span><br><span>index 03d600f..c000e41 100644</span><br><span>--- a/tests/mgcp/mgcp_test.c</span><br><span>+++ b/tests/mgcp/mgcp_test.c</span><br><span>@@ -128,7 +128,7 @@</span><br><span> "a=fmtp:126 0/1/2\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define MDCX4 \</span><br><span style="color: hsl(120, 100%, 40%);">+#define MDCX4_ADDR0000 \</span><br><span> "MDCX 18983216 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: sendrecv\r" \</span><br><span> "C: 2\r\n" \</span><br><span>@@ -143,6 +143,24 @@</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define MDCX4_ADDR0000_RET \</span><br><span style="color: hsl(120, 100%, 40%);">+ "527 18983216 FAIL\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MDCX4 \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983217 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "M: sendrecv\r" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "C: 2\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "I: %s\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "L: p:20, a:AMR, nt:IN\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "v=0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "t=0 0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "a=rtpmap:99 AMR/8000\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "a=ptime:40\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #define MDCX4_RET(Ident) \</span><br><span> "200 " Ident " OK\r\n" \</span><br><span> "\r\n" \</span><br><span>@@ -168,45 +186,45 @@</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span> #define MDCX4_PT1 \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983217 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983218 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: SENDRECV\r" \</span><br><span> "C: 2\r\n" \</span><br><span> "I: %s\r\n" \</span><br><span> "L: p:20-40, a:AMR, nt:IN\r\n" \</span><br><span> "\n" \</span><br><span> "v=0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "o=- %s 23 IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "c=IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span> "t=0 0\r\n" \</span><br><span> "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span> #define MDCX4_PT2 \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983218 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983219 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: sendrecv\r" \</span><br><span> "C: 2\r\n" \</span><br><span> "I: %s\r\n" \</span><br><span> "L: p:20-20, a:AMR, nt:IN\r\n" \</span><br><span> "\n" \</span><br><span> "v=0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "o=- %s 23 IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "c=IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span> "t=0 0\r\n" \</span><br><span> "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span> #define MDCX4_PT3 \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983219 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983220 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: sendrecv\r" \</span><br><span> "C: 2\r\n" \</span><br><span> "I: %s\r\n" \</span><br><span> "L: a:AMR, nt:IN\r\n" \</span><br><span> "\n" \</span><br><span> "v=0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "o=- %s 23 IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "c=IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span> "t=0 0\r\n" \</span><br><span> "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span>@@ -214,47 +232,47 @@</span><br><span> </span><br><span> /* Test different upper/lower case in options */</span><br><span> #define MDCX4_PT4 \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983220 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983221 1@mgw MGCP 1.0\r\n" \</span><br><span> "m: sendrecv\r" \</span><br><span> "c: 2\r\n" \</span><br><span> "i: %s\r\n" \</span><br><span> "l: A:amr, NT:IN\r\n" \</span><br><span> "\n" \</span><br><span> "v=0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "o=- %s 23 IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "c=IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span> "t=0 0\r\n" \</span><br><span> "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span> #define MDCX4_SO \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983221 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983222 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: sendonly\r" \</span><br><span> "C: 2\r\n" \</span><br><span> "I: %s\r\n" \</span><br><span> "L: p:20, a:AMR, nt:IN\r\n" \</span><br><span> "\n" \</span><br><span> "v=0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "o=- %s 23 IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "c=IN IP4 0.0.0.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "o=- %s 23 IN IP4 5.6.7.8\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "c=IN IP4 5.6.7.8\r\n" \</span><br><span> "t=0 0\r\n" \</span><br><span> "m=audio 4441 RTP/AVP 99\r\n" \</span><br><span> "a=rtpmap:99 AMR/8000\r\n" \</span><br><span> "a=ptime:40\r\n"</span><br><span> </span><br><span> #define MDCX4_RO \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983222 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983223 1@mgw MGCP 1.0\r\n" \</span><br><span> "M: recvonly\r" \</span><br><span> "C: 2\r\n" \</span><br><span> "I: %s\r\n" \</span><br><span> "L: p:20, a:AMR, nt:IN\r\n"</span><br><span> </span><br><span> #define MDCX_TOO_LONG_CI \</span><br><span style="color: hsl(0, 100%, 40%);">- "MDCX 18983223 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "MDCX 18983224 1@mgw MGCP 1.0\r\n" \</span><br><span> "I: 123456789012345678901234567890123\n"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define MDCX_TOO_LONG_CI_RET "510 18983223 FAIL\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+#define MDCX_TOO_LONG_CI_RET "510 18983224 FAIL\r\n"</span><br><span> </span><br><span> #define SHORT2 "CRCX 1"</span><br><span> #define SHORT2_RET "510 000000 FAIL\r\n"</span><br><span>@@ -542,13 +560,14 @@</span><br><span> {"MDCX2", MDCX_UNALLOCATED, MDCX_RET},</span><br><span> {"CRCX", CRCX, CRCX_RET, 97},</span><br><span> {"MDCX3", MDCX3, MDCX3_RET, PTYPE_IGNORE},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4", MDCX4, MDCX4_RET("18983216"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_PT1", MDCX4_PT1, MDCX4_RET("18983217"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_PT2", MDCX4_PT2, MDCX4_RET("18983218"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_PT3", MDCX4_PT3, MDCX4_RET("18983219"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_PT4", MDCX4_PT4, MDCX4_RET("18983220"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_SO", MDCX4_SO, MDCX4_RET("18983221"), 99},</span><br><span style="color: hsl(0, 100%, 40%);">- {"MDCX4_RO", MDCX4_RO, MDCX4_RO_RET("18983222"), PTYPE_IGNORE},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_ADDR000", MDCX4_ADDR0000, MDCX4_ADDR0000_RET},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4", MDCX4, MDCX4_RET("18983217"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_PT1", MDCX4_PT1, MDCX4_RET("18983218"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_PT2", MDCX4_PT2, MDCX4_RET("18983219"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_PT3", MDCX4_PT3, MDCX4_RET("18983220"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_PT4", MDCX4_PT4, MDCX4_RET("18983221"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_SO", MDCX4_SO, MDCX4_RET("18983222"), 99},</span><br><span style="color: hsl(120, 100%, 40%);">+ {"MDCX4_RO", MDCX4_RO, MDCX4_RO_RET("18983223"), PTYPE_IGNORE},</span><br><span> {"DLCX", DLCX, DLCX_RET, PTYPE_IGNORE},</span><br><span> {"CRCX_ZYN", CRCX_ZYN, CRCX_ZYN_RET, 97},</span><br><span> {"EMPTY", EMPTY, EMPTY_RET},</span><br><span>diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok</span><br><span>index d3f8a26..575fd83 100644</span><br><span>--- a/tests/mgcp/mgcp_test.ok</span><br><span>+++ b/tests/mgcp/mgcp_test.ok</span><br><span>@@ -97,7 +97,7 @@</span><br><span> Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span style="color: hsl(0, 100%, 40%);">-Testing MDCX4</span><br><span style="color: hsl(120, 100%, 40%);">+Testing MDCX4_ADDR000</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span> MDCX 18983216 1@mgw MGCP 1.0
</span><br><span>@@ -115,22 +115,46 @@</span><br><span> </span><br><span> ---------8<---------</span><br><span> checking response:</span><br><span style="color: hsl(120, 100%, 40%);">+using message as statically defined for comparison</span><br><span style="color: hsl(120, 100%, 40%);">+Response matches our expectations.</span><br><span style="color: hsl(120, 100%, 40%);">+(response does not contain a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+================================================</span><br><span style="color: hsl(120, 100%, 40%);">+Testing MDCX4</span><br><span style="color: hsl(120, 100%, 40%);">+creating message from statically defined input:</span><br><span style="color: hsl(120, 100%, 40%);">+---------8<---------</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983217 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+M: sendrecv
C: 2
</span><br><span style="color: hsl(120, 100%, 40%);">+I: %s
</span><br><span style="color: hsl(120, 100%, 40%);">+L: p:20, a:AMR, nt:IN
</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+v=0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+t=0 0
</span><br><span style="color: hsl(120, 100%, 40%);">+m=audio 4441 RTP/AVP 99
</span><br><span style="color: hsl(120, 100%, 40%);">+a=rtpmap:99 AMR/8000
</span><br><span style="color: hsl(120, 100%, 40%);">+a=ptime:40
</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+---------8<---------</span><br><span style="color: hsl(120, 100%, 40%);">+checking response:</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing MDCX4_PT1</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983217 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983218 1@mgw MGCP 1.0
</span><br><span> M: SENDRECV
C: 2
</span><br><span> I: %s
</span><br><span> L: p:20-40, a:AMR, nt:IN
</span><br><span> </span><br><span> v=0
</span><br><span style="color: hsl(0, 100%, 40%);">-o=- %s 23 IN IP4 0.0.0.0
</span><br><span style="color: hsl(0, 100%, 40%);">-c=IN IP4 0.0.0.0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span> t=0 0
</span><br><span> m=audio 4441 RTP/AVP 99
</span><br><span> a=rtpmap:99 AMR/8000
</span><br><span>@@ -141,19 +165,20 @@</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing MDCX4_PT2</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983218 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983219 1@mgw MGCP 1.0
</span><br><span> M: sendrecv
C: 2
</span><br><span> I: %s
</span><br><span> L: p:20-20, a:AMR, nt:IN
</span><br><span> </span><br><span> v=0
</span><br><span style="color: hsl(0, 100%, 40%);">-o=- %s 23 IN IP4 0.0.0.0
</span><br><span style="color: hsl(0, 100%, 40%);">-c=IN IP4 0.0.0.0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span> t=0 0
</span><br><span> m=audio 4441 RTP/AVP 99
</span><br><span> a=rtpmap:99 AMR/8000
</span><br><span>@@ -164,19 +189,20 @@</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing MDCX4_PT3</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983219 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983220 1@mgw MGCP 1.0
</span><br><span> M: sendrecv
C: 2
</span><br><span> I: %s
</span><br><span> L: a:AMR, nt:IN
</span><br><span> </span><br><span> v=0
</span><br><span style="color: hsl(0, 100%, 40%);">-o=- %s 23 IN IP4 0.0.0.0
</span><br><span style="color: hsl(0, 100%, 40%);">-c=IN IP4 0.0.0.0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span> t=0 0
</span><br><span> m=audio 4441 RTP/AVP 99
</span><br><span> a=rtpmap:99 AMR/8000
</span><br><span>@@ -187,19 +213,20 @@</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing MDCX4_PT4</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983220 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983221 1@mgw MGCP 1.0
</span><br><span> m: sendrecv
c: 2
</span><br><span> i: %s
</span><br><span> l: A:amr, NT:IN
</span><br><span> </span><br><span> v=0
</span><br><span style="color: hsl(0, 100%, 40%);">-o=- %s 23 IN IP4 0.0.0.0
</span><br><span style="color: hsl(0, 100%, 40%);">-c=IN IP4 0.0.0.0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span> t=0 0
</span><br><span> m=audio 4441 RTP/AVP 99
</span><br><span> a=rtpmap:99 AMR/8000
</span><br><span>@@ -210,19 +237,20 @@</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing MDCX4_SO</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983221 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983222 1@mgw MGCP 1.0
</span><br><span> M: sendonly
C: 2
</span><br><span> I: %s
</span><br><span> L: p:20, a:AMR, nt:IN
</span><br><span> </span><br><span> v=0
</span><br><span style="color: hsl(0, 100%, 40%);">-o=- %s 23 IN IP4 0.0.0.0
</span><br><span style="color: hsl(0, 100%, 40%);">-c=IN IP4 0.0.0.0
</span><br><span style="color: hsl(120, 100%, 40%);">+o=- %s 23 IN IP4 5.6.7.8
</span><br><span style="color: hsl(120, 100%, 40%);">+c=IN IP4 5.6.7.8
</span><br><span> t=0 0
</span><br><span> m=audio 4441 RTP/AVP 99
</span><br><span> a=rtpmap:99 AMR/8000
</span><br><span>@@ -238,7 +266,7 @@</span><br><span> Testing MDCX4_RO</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983222 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983223 1@mgw MGCP 1.0
</span><br><span> M: recvonly
C: 2
</span><br><span> I: %s
</span><br><span> L: p:20, a:AMR, nt:IN
</span><br><span>@@ -248,6 +276,7 @@</span><br><span> using message with patched conn_id for comparison</span><br><span> Response matches our expectations.</span><br><span> (response contains a connection id)</span><br><span style="color: hsl(120, 100%, 40%);">+Dummy packets: 2</span><br><span> </span><br><span> ================================================</span><br><span> Testing DLCX</span><br><span>@@ -463,7 +492,7 @@</span><br><span> Testing MDCX_TOO_LONG_CI</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span style="color: hsl(0, 100%, 40%);">-MDCX 18983223 1@mgw MGCP 1.0
</span><br><span style="color: hsl(120, 100%, 40%);">+MDCX 18983224 1@mgw MGCP 1.0
</span><br><span> I: 123456789012345678901234567890123</span><br><span> </span><br><span> ---------8<---------</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24863">change 24863</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/24863"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6ce8cf52930d423d3db8c27251be8350a26a4ede </div>
<div style="display:none"> Gerrit-Change-Number: 24863 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>