<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/24814">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cuart: move generic paramete reset upon powerdown to where it belongs<br><br>Change-Id: I784f66cb998fc04ae64312b809fc3a7c42bd6bff<br>---<br>M ccid_common/cuart.c<br>M sysmoOCTSIM/cuart_driver_asf4_usart_async.c<br>2 files changed, 12 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_common/cuart.c b/ccid_common/cuart.c</span><br><span>index c617754..9966942 100644</span><br><span>--- a/ccid_common/cuart.c</span><br><span>+++ b/ccid_common/cuart.c</span><br><span>@@ -148,6 +148,18 @@</span><br><span>                 else</span><br><span>                         osmo_timer_del(&cuart->wtime_tmr);</span><br><span>            break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case CUART_CTL_POWER_5V0:</span><br><span style="color: hsl(120, 100%, 40%);">+     case CUART_CTL_POWER_3V0:</span><br><span style="color: hsl(120, 100%, 40%);">+     case CUART_CTL_POWER_1V8:</span><br><span style="color: hsl(120, 100%, 40%);">+             /* we have to reset this somewhere, and powering down loses all state</span><br><span style="color: hsl(120, 100%, 40%);">+          * this is not hw specific so it belongs here, after handling the hw specific part */</span><br><span style="color: hsl(120, 100%, 40%);">+         if (!arg) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   cuart->tx_busy = false;</span><br><span style="color: hsl(120, 100%, 40%);">+                    cuart->rx_threshold = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+                   cuart->wtime_etu = 9600; /* ISO 7816-3 Section 8.1 */</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span>       default:</span><br><span>             break;</span><br><span>       }</span><br><span>diff --git a/sysmoOCTSIM/cuart_driver_asf4_usart_async.c b/sysmoOCTSIM/cuart_driver_asf4_usart_async.c</span><br><span>index 7822c1b..42c2110 100644</span><br><span>--- a/sysmoOCTSIM/cuart_driver_asf4_usart_async.c</span><br><span>+++ b/sysmoOCTSIM/cuart_driver_asf4_usart_async.c</span><br><span>@@ -481,12 +481,6 @@</span><br><span>            settings.vsel = v;</span><br><span>           ncn8025_set(cuart->u.asf4.slot_nr, &settings);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               /* we have to reset this somewhere, and powering down loses all state */</span><br><span style="color: hsl(0, 100%, 40%);">-                if (!arg) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     cuart->tx_busy = false;</span><br><span style="color: hsl(0, 100%, 40%);">-                      cuart->wtime_etu = 9600; /* ISO 7816-3 Section 8.1 */</span><br><span style="color: hsl(0, 100%, 40%);">-                }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            break;</span><br><span>       case CUART_CTL_WTIME:</span><br><span>                /* no driver-specific handling of this */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/24814">change 24814</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/24814"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I784f66cb998fc04ae64312b809fc3a7c42bd6bff </div>
<div style="display:none"> Gerrit-Change-Number: 24814 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>