<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24819">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: rather not use decmatch in f_tc_ho_inter_msc_out()<br><br>TC_ho_inter_msc_out fails on jenkins in a way that i cannot reproduce. A<br>possible source is the decmatch for the Handover Request message. The<br>jenkins logs show:<br><br>MSC_Tests.ttcn:6005 Warning: Decoded content matching failed, because the buffer was not empty after decoding. Remaining octets: 22.<br><br>Change-Id: I20b5594c7e083af791525231f24d3ed089c18910<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/24819/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 5c63b63..e548c5c 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -6005,7 +6005,7 @@</span><br><span>     alt {</span><br><span>        [] GSUP.receive(tr_GSUP_E_AN_APDU(OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_REQUEST,</span><br><span>                                 pars.imsi, destination_name := remote_msc_name,</span><br><span style="color: hsl(0, 100%, 40%);">-                         an_apdu := t_GSUP_AN_APDU(OSMO_GSUP_AN_PROTO_48006, decmatch expect_ho_request))) -> value prep_ho_req;</span><br><span style="color: hsl(120, 100%, 40%);">+                            an_apdu := t_GSUP_AN_APDU(OSMO_GSUP_AN_PROTO_48006, pdu := ?))) -> value prep_ho_req;</span><br><span>     [] GSUP.receive(tr_GSUP_E_AN_APDU(OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_REQUEST)) {</span><br><span>              setverdict(fail, "Wrong OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_REQUEST message received");</span><br><span>              mtc.stop;</span><br><span>@@ -6016,10 +6016,14 @@</span><br><span>  f_gsup_find_ie(prep_ho_req, OSMO_GSUP_SOURCE_NAME_IE, source_name_ie);</span><br><span>       var octetstring local_msc_name := source_name_ie.source_name;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       /* To forward the actual chosen encryption algorithm, decode the received PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+      /* Decode PDU to 1) match with expect_ho_request and 2) to forward the actual chosen encryption algorithm. */</span><br><span>        var GSUP_IeValue an_apdu_ie;</span><br><span>         f_gsup_find_ie(prep_ho_req, OSMO_GSUP_AN_APDU_IE, an_apdu_ie);</span><br><span>       ho_request := dec_PDU_BSSAP(an_apdu_ie.an_apdu.pdu);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (not match(ho_request, expect_ho_request)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               setverdict(fail, "Wrong PDU in OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_REQUEST message received");</span><br><span style="color: hsl(120, 100%, 40%);">+                mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        /* Remote MSC has figured out its BSC and signals success */</span><br><span>         var PDU_ML3_NW_MS rr_ho_cmd := valueof(ts_RR_HandoverCommand);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24819">change 24819</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24819"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I20b5594c7e083af791525231f24d3ed089c18910 </div>
<div style="display:none"> Gerrit-Change-Number: 24819 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>