<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24816">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: fix inter-msc ho tests: do not attempt to send "*"<br><br>Recently, encryption testing was added to the inter-MSC HO test. Instead<br>of sending the chosenEncryptionAlgorithm from the receive-template side<br>forward the actual received one (rx "*" usually means tx is "omit").<br><br>Change-Id: Icae084cfd63d666f3b0778fade7ba558bd161a0f<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 12 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/24816/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index b12fb5e..5c63b63 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -5954,6 +5954,7 @@</span><br><span> </span><br><span> private function f_tc_ho_inter_msc_out(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span>       var CallParameters cpars;</span><br><span style="color: hsl(120, 100%, 40%);">+     var PDU_BSSAP ho_request;</span><br><span> </span><br><span>        cpars := valueof(t_CallParams('12345'H, 0));</span><br><span>         if (pars.use_ipv6) {</span><br><span>@@ -6015,13 +6016,18 @@</span><br><span>       f_gsup_find_ie(prep_ho_req, OSMO_GSUP_SOURCE_NAME_IE, source_name_ie);</span><br><span>       var octetstring local_msc_name := source_name_ie.source_name;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     /* To forward the actual chosen encryption algorithm, decode the received PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+      var GSUP_IeValue an_apdu_ie;</span><br><span style="color: hsl(120, 100%, 40%);">+  f_gsup_find_ie(prep_ho_req, OSMO_GSUP_AN_APDU_IE, an_apdu_ie);</span><br><span style="color: hsl(120, 100%, 40%);">+        ho_request := dec_PDU_BSSAP(an_apdu_ie.an_apdu.pdu);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       /* Remote MSC has figured out its BSC and signals success */</span><br><span>         var PDU_ML3_NW_MS rr_ho_cmd := valueof(ts_RR_HandoverCommand);</span><br><span>       var octetstring rr_ho_cmd_enc := enc_PDU_ML3_NW_MS(rr_ho_cmd);</span><br><span>       var PDU_BSSAP ho_req_ack := valueof(ts_BSSMAP_HandoverRequestAcknowledge(rr_ho_cmd_enc, lengthof(rr_ho_cmd_enc),</span><br><span style="color: hsl(0, 100%, 40%);">-                                        aoIPTransportLayer := omit,</span><br><span style="color: hsl(0, 100%, 40%);">-                                     speechCodec := ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}),</span><br><span style="color: hsl(0, 100%, 40%);">-                                  chosenEncryptionAlgorithm := chosenEncryptionAlgorithm));</span><br><span style="color: hsl(120, 100%, 40%);">+                     aoIPTransportLayer := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+                   speechCodec := ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}),</span><br><span style="color: hsl(120, 100%, 40%);">+                        chosenEncryptionAlgorithm := ho_request.pdu.bssmap.handoverRequest.chosenEncryptionAlgorithm));</span><br><span>      GSUP.send(ts_GSUP_E_PrepareHandoverResult(</span><br><span>                           pars.imsi,</span><br><span>                           ho_number,</span><br><span>@@ -6159,9 +6165,8 @@</span><br><span>   /* MSC asks local BSS to prepare Handover to it */</span><br><span>   f_get_expected_encryption(encryptionInformation, chosenEncryptionAlgorithm, kC128, a5_perm_alg);</span><br><span>     expect_ho_request := tr_BSSMAP_HandoverRequest(encryptionInformation, chosenEncryptionAlgorithm, kC128);</span><br><span style="color: hsl(0, 100%, 40%);">-        var PDU_BSSAP ho_request;</span><br><span>    alt {</span><br><span style="color: hsl(0, 100%, 40%);">-   [] BSSAP.receive(expect_ho_request);</span><br><span style="color: hsl(120, 100%, 40%);">+  [] BSSAP.receive(expect_ho_request) -> value ho_request;</span><br><span>  [] BSSAP.receive(tr_BSSMAP_HandoverRequest) -> value ho_request {</span><br><span>                 log("Error: Wrong handoverRequest received. Expected: ", expect_ho_request,</span><br><span>                    " got ", ho_request);</span><br><span>@@ -6179,8 +6184,8 @@</span><br><span>  var BSSMAP_IE_AoIP_TransportLayerAddress tla :=</span><br><span>              valueof(f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port));</span><br><span>      BSSAP.send(ts_BSSMAP_HandoverRequestAcknowledge(rr_ho_cmd_enc, lengthof(rr_ho_cmd_enc),</span><br><span style="color: hsl(0, 100%, 40%);">-                                                 tla, ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}),</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    chosenEncryptionAlgorithm := chosenEncryptionAlgorithm));</span><br><span style="color: hsl(120, 100%, 40%);">+                     tla, ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}),</span><br><span style="color: hsl(120, 100%, 40%);">+                  chosenEncryptionAlgorithm := ho_request.pdu.bssmap.handoverRequest.chosenEncryptionAlgorithm));</span><br><span> </span><br><span>  /* HandoverCommand goes out via remote MSC-I */</span><br><span>      var GSUP_PDU prep_subsq_ho_res;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24816">change 24816</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24816"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icae084cfd63d666f3b0778fade7ba558bd161a0f </div>
<div style="display:none"> Gerrit-Change-Number: 24816 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>