<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24806">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_decision_2.c: add current_rxqual()<br><br>Pre-empt code dup: this will be also used by an upcoming patch, so first<br>put it in a function.<br><br>Change-Id: I0d5bdaa9605f2bd4241cdd47ccf1ce1c697818a8<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index c9d1198..7a14f06 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -250,6 +250,15 @@</span><br><span>                             ho_get_hodec2_rxlev_avg_win(bts->ho));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int current_rxqual(struct gsm_lchan *lchan)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+   return get_meas_rep_avg(lchan,</span><br><span style="color: hsl(120, 100%, 40%);">+                                ho_get_hodec2_full_tdma(bts->ho) ?</span><br><span style="color: hsl(120, 100%, 40%);">+                                 MEAS_REP_DL_RXQUAL_FULL : MEAS_REP_DL_RXQUAL_SUB,</span><br><span style="color: hsl(120, 100%, 40%);">+                             ho_get_hodec2_rxqual_avg_win(bts->ho));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static bool is_low_rxlev(int rxlev_current, struct handover_cfg *neigh_cfg)</span><br><span> {</span><br><span>  return rxlev_current >= 0</span><br><span>@@ -1464,10 +1473,7 @@</span><br><span> </span><br><span>    /* get average levels. if not enough measurements yet, value is < 0 */</span><br><span>    av_rxlev = current_rxlev(lchan);</span><br><span style="color: hsl(0, 100%, 40%);">-        av_rxqual = get_meas_rep_avg(lchan,</span><br><span style="color: hsl(0, 100%, 40%);">-                                  ho_get_hodec2_full_tdma(bts->ho) ?</span><br><span style="color: hsl(0, 100%, 40%);">-                                   MEAS_REP_DL_RXQUAL_FULL : MEAS_REP_DL_RXQUAL_SUB,</span><br><span style="color: hsl(0, 100%, 40%);">-                               ho_get_hodec2_rxqual_avg_win(bts->ho));</span><br><span style="color: hsl(120, 100%, 40%);">+       av_rxqual = current_rxqual(lchan);</span><br><span>   if (av_rxlev < 0 && av_rxqual < 0) {</span><br><span>           LOGPHOLCHAN(lchan, LOGL_INFO, "Skipping, Not enough recent measurements\n");</span><br><span>               return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24806">change 24806</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24806"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0d5bdaa9605f2bd4241cdd47ccf1ce1c697818a8 </div>
<div style="display:none"> Gerrit-Change-Number: 24806 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>