<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24807">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add fixme: enforce 8 byte length of Kc<br><br>Change-Id: I57efb0a24cb71b365189eccb5088b130fad15093<br>---<br>M src/gsm/gsm0808_utils.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/24807/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c</span><br><span>index b5b8431..78cbe92 100644</span><br><span>--- a/src/gsm/gsm0808_utils.c</span><br><span>+++ b/src/gsm/gsm0808_utils.c</span><br><span>@@ -721,6 +721,8 @@</span><br><span>        }</span><br><span> </span><br><span>        msgb_put_u8(msg, perm_algo);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* FIXME: 48.008 3.2.2.10 Encryption Information says:</span><br><span style="color: hsl(120, 100%, 40%);">+         * "When present, the key shall be 8 octets long." */</span><br><span>      ptr = msgb_put(msg, ei->key_len);</span><br><span>         memcpy(ptr, ei->key, ei->key_len);</span><br><span> </span><br><span>@@ -760,6 +762,8 @@</span><br><span>   }</span><br><span>    ei->perm_algo_len = perm_algo_len;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     /* FIXME: 48.008 3.2.2.10 Encryption Information says:</span><br><span style="color: hsl(120, 100%, 40%);">+         * "When present, the key shall be 8 octets long." */</span><br><span>      ei->key_len = len - 1;</span><br><span>    memcpy(ei->key, elem, ei->key_len);</span><br><span>    elem+=ei->key_len;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24807">change 24807</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24807"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I57efb0a24cb71b365189eccb5088b130fad15093 </div>
<div style="display:none"> Gerrit-Change-Number: 24807 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>