<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24805">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_decision_2.c: add is_low_rxlev()<br><br>Remove code dup. Also this will be used another time by an upcoming<br>patch.<br><br>Change-Id: I4aaeb8bc35a142962ac8ca6401a76b0733f7979e<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 9 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/24805/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index d4ebc41..97c8b6e 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -250,6 +250,12 @@</span><br><span>                            ho_get_hodec2_rxlev_avg_win(bts->ho));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static bool is_low_rxlev(int rxlev_current, struct handover_cfg *neigh_cfg)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    return rxlev_current >= 0</span><br><span style="color: hsl(120, 100%, 40%);">+          && rxlev2dbm(rxlev_current) < ho_get_hodec2_min_rxlev(neigh_cfg);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* obtain averaged rxlev for given neighbor */</span><br><span> static int neigh_meas_avg(struct neigh_meas_proc *nmp, int window)</span><br><span> {</span><br><span>@@ -1069,7 +1075,6 @@</span><br><span>               .bsic = nmp->bsic,</span><br><span>        };</span><br><span>   struct ho_candidate c;</span><br><span style="color: hsl(0, 100%, 40%);">-  int min_rxlev;</span><br><span>       struct handover_cfg *neigh_cfg;</span><br><span> </span><br><span>  /* skip empty slots */</span><br><span>@@ -1137,12 +1142,11 @@</span><br><span> </span><br><span>         /* if the minimum level is not reached.</span><br><span>       * In case of a remote-BSS, use the current BTS' configuration. */</span><br><span style="color: hsl(0, 100%, 40%);">-  min_rxlev = ho_get_hodec2_min_rxlev(neigh_cfg);</span><br><span style="color: hsl(0, 100%, 40%);">- if (rxlev2dbm(c.target.rxlev) < min_rxlev) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (is_low_rxlev(c.target.rxlev, neigh_cfg)) {</span><br><span>               LOGPHOCAND(&c, LOGL_DEBUG,</span><br><span>                          "Not a candidate, because RX level (%d dBm) is lower"</span><br><span>                      " than the minimum required RX level (%d dBm)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                     rxlev2dbm(c.target.rxlev), min_rxlev);</span><br><span style="color: hsl(120, 100%, 40%);">+                        rxlev2dbm(c.target.rxlev), ho_get_hodec2_min_rxlev(neigh_cfg));</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span>@@ -1505,7 +1509,7 @@</span><br><span>        }</span><br><span> </span><br><span>        /* Low Level */</span><br><span style="color: hsl(0, 100%, 40%);">- if (av_rxlev >= 0 && rxlev2dbm(av_rxlev) < ho_get_hodec2_min_rxlev(bts->ho)) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (is_low_rxlev(av_rxlev, bts->ho)) {</span><br><span>            global_ho_reason = HO_REASON_LOW_RXLEVEL;</span><br><span>            LOGPHOLCHAN(lchan, LOGL_NOTICE, "RX level is TOO LOW: %d < %d\n",</span><br><span>                           rxlev2dbm(av_rxlev), ho_get_hodec2_min_rxlev(bts->ho));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24805">change 24805</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24805"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4aaeb8bc35a142962ac8ca6401a76b0733f7979e </div>
<div style="display:none"> Gerrit-Change-Number: 24805 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>