<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c">File src/common/rsl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c@2212">Patch Set #1, Line 2212:</a> <code style="font-family:monospace,monospace"> ts->bcch_power_red_db = 2;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Aren't you overwriting this value upon next loop iteration in "ts->bcch_power_red_db = 0;" (line 2202)?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c@3604">Patch Set #1, Line 3604:</a> <code style="font-family:monospace,monospace"> /* Osmocom specific extension for BCCH carrier power reduction */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Some reference to spec here or above in the function would be helpful, specially since this seem to be available only since recent versions.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/scheduler.c">File src/common/scheduler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/scheduler.c@1322">Patch Set #1, Line 1322:</a> <code style="font-family:monospace,monospace"> br->att = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why is this needed?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24776">change 24776</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24776"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3dcee6e910ccc61c5c63c728db9ea04327e2fc98 </div>
<div style="display:none"> Gerrit-Change-Number: 24776 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 28 Jun 2021 08:22:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>