<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24780">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan-select: Avoid setting variable for no reason<br><br>That variable is never used after being set. Furthermore, it is being<br>set to the same value already stored, so there's no use in setting it<br>and it creates confusion.<br><br>Change-Id: Ib6ee28aa9a449992f5d3dea6df7dd2b7e30e73c9<br>---<br>M src/osmo-bsc/lchan_select.c<br>1 file changed, 3 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/24780/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c</span><br><span>index 53c4358..a1f6c82 100644</span><br><span>--- a/src/osmo-bsc/lchan_select.c</span><br><span>+++ b/src/osmo-bsc/lchan_select.c</span><br><span>@@ -220,35 +220,24 @@</span><br><span>   case GSM_LCHAN_TCH_F:</span><br><span>                lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_F, log);</span><br><span>             /* If we don't have TCH/F available, try dynamic TCH/F_PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-              if (!lchan) {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (!lchan)</span><br><span>                  lchan = _lc_dyn_find_bts(bts, GSM_PCHAN_TCH_F_PDCH,</span><br><span>                                           GSM_PCHAN_TCH_F, log);</span><br><span style="color: hsl(0, 100%, 40%);">-                 /* TCH/F_PDCH used as TCH/F -- here, type is already</span><br><span style="color: hsl(0, 100%, 40%);">-                     * set to GSM_LCHAN_TCH_F, but for clarity's sake... */</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_F;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span> </span><br><span>                /* Try fully dynamic TCH/F_TCH/H_PDCH as TCH/F... */</span><br><span style="color: hsl(0, 100%, 40%);">-            if (!lchan && bts->network->dyn_ts_allow_tch_f) {</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!lchan && bts->network->dyn_ts_allow_tch_f)</span><br><span>                        lchan = _lc_dyn_find_bts(bts,</span><br><span>                                                 GSM_PCHAN_TCH_F_TCH_H_PDCH,</span><br><span>                                                  GSM_PCHAN_TCH_F, log);</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_F;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            break;</span><br><span>       case GSM_LCHAN_TCH_H:</span><br><span>                lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H, log);</span><br><span>             /* No dedicated TCH/x available -- try fully dynamic</span><br><span>                  * TCH/F_TCH/H_PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!lchan) {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (!lchan)</span><br><span>                  lchan = _lc_dyn_find_bts(bts,</span><br><span>                                                 GSM_PCHAN_TCH_F_TCH_H_PDCH,</span><br><span>                                                  GSM_PCHAN_TCH_H, log);</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_H;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            break;</span><br><span>       default:</span><br><span>             LOG_BTS(bts, DRLL, LOGL_ERROR, "Unknown gsm_chan_t %u\n", type);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24780">change 24780</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24780"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib6ee28aa9a449992f5d3dea6df7dd2b7e30e73c9 </div>
<div style="display:none"> Gerrit-Change-Number: 24780 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>