<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/24765">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">support A5/4 in inter-BSC handover<br><br>Forward the Kc128 key to the new BSS in BSSMAP Handover Request.<br><br>Depends: Ieb6e43eef9e57281d54d4b7c63664668df5aef3e (libosmocore)<br>Change-Id: Id5ce995a741c8e469a50a0c46e53c06a2378bb7e<br>---<br>M TODO-RELEASE<br>M src/libmsc/ran_msg_a.c<br>2 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 2297063..d969e50 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -7,4 +7,4 @@</span><br><span> # If any interfaces have been added since the last public release: c:r:a + 1.</span><br><span> # If any interfaces have been removed or changed since the last public release: c:r:0.</span><br><span> #library        what            description / commit summary line</span><br><span style="color: hsl(0, 100%, 40%);">-libosmocore    >1.5.1               A5/4 support requires new API gsm0808_create_cipher2()</span><br><span style="color: hsl(120, 100%, 40%);">+libosmocore     >1.5.1               A5/4 support requires new API gsm0808_create_cipher2(), and gsm0808_handover_request.kc128</span><br><span>diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c</span><br><span>index 106c2df..273f8dd 100644</span><br><span>--- a/src/libmsc/ran_msg_a.c</span><br><span>+++ b/src/libmsc/ran_msg_a.c</span><br><span>@@ -483,6 +483,7 @@</span><br><span>        const struct tlv_p_entry *ie_aoip_transp_addr = TLVP_GET(tp, GSM0808_IE_AOIP_TRASP_ADDR);</span><br><span>    const struct tlv_p_entry *ie_codec_list_msc_preferred = TLVP_GET(tp, GSM0808_IE_SPEECH_CODEC_LIST);</span><br><span>  const struct tlv_p_entry *ie_call_id = TLVP_GET(tp, GSM0808_IE_CALL_ID);</span><br><span style="color: hsl(120, 100%, 40%);">+      const struct tlv_p_entry *ie_kc128 = TLVP_GET(tp, GSM0808_IE_KC_128);</span><br><span>        const struct tlv_p_entry *ie_global_call_ref = TLVP_GET(tp, GSM0808_IE_GLOBAL_CALL_REF);</span><br><span> </span><br><span>         struct gsm0808_channel_type channel_type;</span><br><span>@@ -525,6 +526,11 @@</span><br><span>                     geran_encr.key_len = encr_info.key_len;</span><br><span>              }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         if (ie_kc128) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       memcpy(geran_encr.kc128, ie_kc128->val, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+                       geran_encr.kc128_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          r->geran.chosen_encryption = &geran_encr;</span><br><span>     }</span><br><span> </span><br><span>@@ -1166,6 +1172,12 @@</span><br><span>                      n->geran.chosen_encryption->key, n->geran.chosen_encryption->key_len);</span><br><span>            r.encryption_information.key_len = n->geran.chosen_encryption->key_len;</span><br><span>                r.chosen_encryption_algorithm_serving = n->geran.chosen_encryption->alg_id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           if (n->geran.chosen_encryption->kc128_present) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        r.more_items = true;</span><br><span style="color: hsl(120, 100%, 40%);">+                  memcpy(r.kc128, n->geran.chosen_encryption->kc128, sizeof(r.kc128));</span><br><span style="color: hsl(120, 100%, 40%);">+                    r.kc128_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span>    }</span><br><span> </span><br><span>        if (n->classmark)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/24765">change 24765</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/24765"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id5ce995a741c8e469a50a0c46e53c06a2378bb7e </div>
<div style="display:none"> Gerrit-Change-Number: 24765 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>