<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/24766">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">improve logging on encryption, for Ciphering and HO<br><br>log the algorithm and all keys instead of just Kc.<br><br>Change-Id: If7871dedda2b1fb115e6f00da1379ff2e3d68a10<br>---<br>M src/libmsc/msc_a.c<br>M src/libmsc/msc_ho.c<br>2 files changed, 14 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/24766/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index 4c38c56..451220a 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -345,8 +345,12 @@</span><br><span>  }</span><br><span> </span><br><span>        if (msc_a->geran_encr.key_len)</span><br><span style="color: hsl(0, 100%, 40%);">-               LOG_MSC_A(msc_a, LOGL_DEBUG, "RAN encoding chose ciphering key %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   osmo_hexdump_nospc(msc_a->geran_encr.key, msc_a->geran_encr.key_len));</span><br><span style="color: hsl(120, 100%, 40%);">+                LOG_MSC_A(msc_a, LOGL_DEBUG, "RAN encoding chose ciphering: A5/%d kc %s kc128 %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                          msc_a->geran_encr.alg_id - 1,</span><br><span style="color: hsl(120, 100%, 40%);">+                      osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.key, msc_a->geran_encr.key_len),</span><br><span style="color: hsl(120, 100%, 40%);">+                     msc_a->geran_encr.kc128_present ?</span><br><span style="color: hsl(120, 100%, 40%);">+                            osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.kc128, sizeof(msc_a->geran_encr.kc128))</span><br><span style="color: hsl(120, 100%, 40%);">+                      : "-");</span><br><span>        return 0;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c</span><br><span>index d89a24c..6b8960e 100644</span><br><span>--- a/src/libmsc/msc_ho.c</span><br><span>+++ b/src/libmsc/msc_ho.c</span><br><span>@@ -408,6 +408,14 @@</span><br><span>           },</span><br><span>   };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        if (msc_a->geran_encr.key_len)</span><br><span style="color: hsl(120, 100%, 40%);">+             LOG_MSC_A(msc_a, LOGL_DEBUG, "HO Request with ciphering: A5/%d kc %s kc128 %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     msc_a->geran_encr.alg_id - 1,</span><br><span style="color: hsl(120, 100%, 40%);">+                      osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.key, msc_a->geran_encr.key_len),</span><br><span style="color: hsl(120, 100%, 40%);">+                     msc_a->geran_encr.kc128_present ?</span><br><span style="color: hsl(120, 100%, 40%);">+                            osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.kc128, sizeof(msc_a->geran_encr.kc128))</span><br><span style="color: hsl(120, 100%, 40%);">+                      : "-");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      if (msc_a->cc.active_trans) {</span><br><span>             if (mncc_bearer_cap_to_channel_type(&channel_type, &msc_a->cc.active_trans->bearer_cap)) {</span><br><span>                     msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/24766">change 24766</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/24766"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If7871dedda2b1fb115e6f00da1379ff2e3d68a10 </div>
<div style="display:none"> Gerrit-Change-Number: 24766 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>