<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24729">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">support A5/4 in inter-BSC Handover<br><br>inter-BSC into this BSC: from BSSMAP Handover Request, parse and store<br>Kc128. All else is already implemented: depending on the chosen<br>encryption algorithm, Kc128 will end up in the Channel Activation.<br><br>inter-BSC out of this BSC: nothing is needed to support A5/4, the BSSMAP<br>Handover Required message does not contain any encryption related<br>information. The MSC already knows the chosen algorithm.<br><br>Related: SYS#5324<br>Change-Id: I7e9590e8c96aa50086148863ad9a2741b978e614<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/handover_fsm.c<br>2 files changed, 21 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/24729/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 1755b92..c5d2b86 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -241,6 +241,8 @@</span><br><span> struct gsm0808_channel_type ct;</span><br><span> struct gsm0808_speech_codec_list scl;</span><br><span> struct gsm0808_encrypt_info ei;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool kc128_present;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t kc128[16];</span><br><span> struct gsm_classmark classmark;</span><br><span> /* chosen_encr_alg reflects the encoded value as in RSL_ENC_ALG_A5(a5_numer):</span><br><span> * chosen_encr_alg == 1 means A5/0 i.e. no encryption, chosen_encr_alg == 4 means A5/3.</span><br><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index cae5167..5f4b892 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -454,6 +454,7 @@</span><br><span> int payload_length;</span><br><span> bool aoip = gscon_is_aoip(conn);</span><br><span> bool sccplite = gscon_is_sccplite(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+ bool has_a54 = false;</span><br><span> </span><br><span> if ((aoip && sccplite) || !(aoip || sccplite)) {</span><br><span> LOG_HO(conn, LOGL_ERROR, "Received BSSMAP Handover Request, but conn is not"</span><br><span>@@ -485,6 +486,15 @@</span><br><span> return false;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if ((e = TLVP_GET(tp, GSM0808_IE_KC_128))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (e->len != 16) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_HO(conn, LOGL_ERROR, "Invalid length in Kc128 IE: %u bytes (expected 16)\n", e->len);</span><br><span style="color: hsl(120, 100%, 40%);">+ return false;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(req->kc128, e->val, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ req->kc128_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if ((e = TLVP_GET(tp, GSM0808_IE_CLASSMARK_INFORMATION_TYPE_1))) {</span><br><span> if (e->len != sizeof(req->classmark.classmark1)) {</span><br><span> LOG_HO(conn, LOGL_ERROR, "Classmark Information 1 has wrong size\n");</span><br><span>@@ -513,9 +523,10 @@</span><br><span> req->chosen_encr_alg);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOG_HO(conn, LOGL_DEBUG, "Handover Request encryption info: chosen=A5/%u key=%s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- (req->chosen_encr_alg ? : 1) - 1, req->ei.key_len?</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexdump_nospc(req->ei.key, req->ei.key_len) : "none");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_HO(conn, LOGL_DEBUG, "Handover Request encryption info: chosen=A5/%u key=%s kc128=%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ (req->chosen_encr_alg ? : 1) - 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ req->ei.key_len ? osmo_hexdump_nospc(req->ei.key, req->ei.key_len) : "none",</span><br><span style="color: hsl(120, 100%, 40%);">+ has_a54 ? osmo_hexdump_nospc(req->kc128, 16) : "none");</span><br><span> </span><br><span> if (TLVP_PRESENT(tp, GSM0808_IE_AOIP_TRASP_ADDR)) {</span><br><span> int rc;</span><br><span>@@ -720,6 +731,11 @@</span><br><span> info.encr.key_len = req->ei.key_len;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (req->kc128_present) {</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(info.encr.kc128, req->kc128, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ info.encr.kc128_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (req->last_eutran_plmn_valid) {</span><br><span> conn->fast_return.allowed = ho->new_bts->srvcc_fast_return_allowed;</span><br><span> conn->fast_return.last_eutran_plmn_valid = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24729">change 24729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24729"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e9590e8c96aa50086148863ad9a2741b978e614 </div>
<div style="display:none"> Gerrit-Change-Number: 24729 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>