<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24732">View Change</a></p><div style="white-space:pre-wrap">Approvals:
neels: Looks good to me, approved
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: also allow empty key for A5/0<br><br>Change-Id: Id54abc09dd62d7247a970a03ed8c2209b641f511<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 12712db..9b6f8b1 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -718,7 +718,7 @@</span><br><span> var PDU_BSSAP bssap;</span><br><span> var RSL_Message rsl;</span><br><span> var RSL_AlgId alg_rsl;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring expect_kc;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template octetstring expect_kc;</span><br><span> </span><br><span> if (isvalue(enc.enc_kc128)) {</span><br><span> BSSAP.send(ts_BSSMAP_CipherModeCmdKc128(enc.enc_alg, enc.enc_key, valueof(enc.enc_kc128)));</span><br><span>@@ -732,6 +732,13 @@</span><br><span> </span><br><span> if (alg_rsl == RSL_ALG_ID_A5_4 and ispresent(enc.enc_kc128)) {</span><br><span> expect_kc := enc.enc_kc128;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (alg_rsl == RSL_ALG_ID_A5_0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* When A5/0 is chosen, no encryption is active, so technically, no key is needed. However, 3GPP TS</span><br><span style="color: hsl(120, 100%, 40%);">+ * 48.058 9.3.7 Encryption Information stays quite silent about presence or absence of a key for A5/0.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The only thing specified is how to indicate the length of the key; the possibility that the key may</span><br><span style="color: hsl(120, 100%, 40%);">+ * be zero length is not explicitly mentioned. So it seems that we should always send the key along,</span><br><span style="color: hsl(120, 100%, 40%);">+ * even for A5/0. Still, let's also allow a zero length key for A5/0. */</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_kc := (enc.enc_key, ''O);</span><br><span> } else {</span><br><span> expect_kc := enc.enc_key;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24732">change 24732</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24732"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id54abc09dd62d7247a970a03ed8c2209b641f511 </div>
<div style="display:none"> Gerrit-Change-Number: 24732 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>