<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util: fix the functions "create_netns" and "setcap_netsys_admin".<br><br>This commit fixes 2 functions from util.py:<br> - setcap_netsys_admin: removed "self" from the arguments.<br> - create_netns: pass "run_dir" to Process and convert the arguments to<br>a list as the other methods in the file.<br><br>Change-Id: Ida4c6d6500be92b8d1f96e4e7a870e63bd329be9<br>---<br>M src/osmo_gsm_tester/core/util.py<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/core/util.py b/src/osmo_gsm_tester/core/util.py</span><br><span>index 691b489..5ca6ad9 100644</span><br><span>--- a/src/osmo_gsm_tester/core/util.py</span><br><span>+++ b/src/osmo_gsm_tester/core/util.py</span><br><span>@@ -102,7 +102,7 @@</span><br><span>     proc = Process(SETCAP_NET_ADMIN_BIN, run_dir, ['sudo', SETCAP_NET_ADMIN_BIN, binary])</span><br><span>     proc.launch_sync()</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-def setcap_netsys_admin(self, binary, run_dir):</span><br><span style="color: hsl(120, 100%, 40%);">+def setcap_netsys_admin(binary, run_dir):</span><br><span>     '''</span><br><span>     This functionality requires specific setup on the host running</span><br><span>     osmo-gsm-tester. See osmo-gsm-tester manual for more information.</span><br><span>@@ -118,7 +118,7 @@</span><br><span>     '''</span><br><span>     from .process import Process</span><br><span>     NETNS_SETUP_BIN = 'osmo-gsm-tester_netns_setup.sh'</span><br><span style="color: hsl(0, 100%, 40%);">-    proc = Process('create_netns', ('sudo', NETNS_SETUP_BIN, netns))</span><br><span style="color: hsl(120, 100%, 40%);">+    proc = Process('create_netns',run_dir, ['sudo', NETNS_SETUP_BIN, netns])</span><br><span>     proc.launch_sync()</span><br><span> </span><br><span> def move_iface_to_netns(ifname, netns, run_dir):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678">change 24678</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ida4c6d6500be92b8d1f96e4e7a870e63bd329be9 </div>
<div style="display:none"> Gerrit-Change-Number: 24678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: alealcon <alejandro.leal@srs.io> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>