<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24665">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Fix race condition exiting f_ho_out_of_this_bsc<br><br>The function didn't wait to receive the 2 messages from the BSC. As a<br>result, they may have arrived while tearing down the test components<br>shortly after exiting the function and provoke a Dynamic Test Error<br>while pushing the messages up the stack since some of the stack layers<br>may already be unavailable.<br><br>Test TC_ho_out_of_this_bsc() workarounded this by using a f_sleep(1),<br>but TC_srvcc_eutran_to_geran_ho_out() didn't, making it fail sometimes.<br><br>Change-Id: I590b09353900dfe6c4f648812ab675fed1908589<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/24665/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 41deea1..074fa60 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -4858,6 +4858,12 @@</span><br><span>   BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span>       f_expect_dlcx_conns();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      interleave {</span><br><span style="color: hsl(120, 100%, 40%);">+  [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE));</span><br><span style="color: hsl(120, 100%, 40%);">+    [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+        [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span>    setverdict(pass);</span><br><span> }</span><br><span> </span><br><span>@@ -4870,7 +4876,6 @@</span><br><span>   f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span>   f_ho_out_of_this_bsc();</span><br><span style="color: hsl(0, 100%, 40%);">- f_sleep(1.0);</span><br><span> }</span><br><span> testcase TC_ho_out_of_this_bsc() runs on test_CT {</span><br><span>     var MSC_ConnHdlr vc_conn;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24665">change 24665</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24665"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I590b09353900dfe6c4f648812ab675fed1908589 </div>
<div style="display:none"> Gerrit-Change-Number: 24665 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>