<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: f_cipher_mode(): fail quicker on key mismatch<br><br>Related: SYS#5324<br>Change-Id: Ia79779f4229da4a5af271235a5e82c6fd59ea3a2<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/24670/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 799d41e..d902301 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -730,6 +730,8 @@</span><br><span> </span><br><span>        if (alg_rsl == RSL_ALG_ID_A5_4 and ispresent(enc.enc_kc128)) {</span><br><span>               expect_kc := enc.enc_kc128;</span><br><span style="color: hsl(120, 100%, 40%);">+   } else if (alg_rsl == RSL_ALG_ID_A5_0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              expect_kc := ''O;</span><br><span>    } else {</span><br><span>             expect_kc := enc.enc_key;</span><br><span>    }</span><br><span>@@ -737,9 +739,19 @@</span><br><span> </span><br><span>         alt {</span><br><span>        /* RSL/UE Side */</span><br><span style="color: hsl(0, 100%, 40%);">-       [] RSL.receive(tr_RSL_ENCR_CMD(g_chan_nr, ?, alg_rsl, expect_kc)) -> value rsl {</span><br><span style="color: hsl(120, 100%, 40%);">+   [] RSL.receive(tr_RSL_ENCR_CMD(g_chan_nr, ?, alg_rsl, ?)) -> value rsl {</span><br><span>          var PDU_ML3_NW_MS l3 := dec_PDU_ML3_NW_MS(rsl.ies[3].body.l3_info.payload);</span><br><span>          log("Rx L3 from net: ", l3);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+              var RSL_IE_Body encr_info;</span><br><span style="color: hsl(120, 100%, 40%);">+            if (not f_rsl_find_ie(rsl, RSL_IE_ENCR_INFO, encr_info)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Missing Encryption IE in RSL ENCR CMD");</span><br><span style="color: hsl(120, 100%, 40%);">+                } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (not match(encr_info, tr_EncrInfo(alg_rsl, expect_kc))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                          Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                    "Unexpected Kc in Encryption IE in RSL ENCR CMD");</span><br><span style="color: hsl(120, 100%, 40%);">+                  }</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            if (ischosen(l3.msgs.rrm.cipheringModeCommand)) {</span><br><span>                    f_rsl_reply(ts_RRM_CiphModeCompl, rsl);</span><br><span>              }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670">change 24670</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia79779f4229da4a5af271235a5e82c6fd59ea3a2 </div>
<div style="display:none"> Gerrit-Change-Number: 24670 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>