<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24640">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  fixeria: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl: Support recovering from short write<br><br>osmo_wqueue has support for it, so simply handle it correctly in the<br>callback (updating buffer and returning -EAGAIN).<br><br>Related: OS#5169<br>Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4<br>---<br>M src/ctrl/control_if.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c</span><br><span>index d117fcf..0a893ba 100644</span><br><span>--- a/src/ctrl/control_if.c</span><br><span>+++ b/src/ctrl/control_if.c</span><br><span>@@ -489,8 +489,14 @@</span><br><span>                control_close_conn(ccon);</span><br><span>            return -EBADF;</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (rc != msg->len)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rc < 0) {</span><br><span>             LOGP(DLCTRL, LOGL_ERROR, "Failed to write message to the CTRL connection.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc < msg->len) {</span><br><span style="color: hsl(120, 100%, 40%);">+            msgb_pull(msg, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+           return -EAGAIN;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24640">change 24640</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24640"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4 </div>
<div style="display:none"> Gerrit-Change-Number: 24640 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>