<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: implement ttcn API and cfg for A5/4<br><br>Implement tools for OsmoBSC a5/4 support testing:<br><br>- add g_pars.encr.enc_kc128<br>- in f_cipher_mode() and f_check_chan_act(), expect Kc128 key as<br> appropriate.<br>- osmo-bsc.cfg: allow a5/4<br><br>Related: SYS#5324<br>Change-Id: Ifa48a8498dde7d04fb29f497013bdb5a1e5f3597<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/MSC_ConnectionHandler.ttcn<br>M bsc/osmo-bsc.cfg<br>3 files changed, 25 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/24669/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index e3720e5..b9e6bfd 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -3461,7 +3461,7 @@</span><br><span> f_init(1, true);</span><br><span> f_sleep(1.0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- pars.encr := valueof(t_EncrParams('20'O, f_rnd_octstring(8)));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.encr := valueof(t_EncrParams('20'O, f_rnd_octstring(8), f_rnd_octstring(16)));</span><br><span> vc_conn := f_start_handler(refers(f_TC_assignment_a5_not_sup), pars);</span><br><span> vc_conn.done;</span><br><span> f_shutdown_helper();</span><br><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index c266c19..799d41e 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -544,12 +544,14 @@</span><br><span> </span><br><span> type record TestHdlrEncrParams {</span><br><span> OCT1 enc_alg,</span><br><span style="color: hsl(0, 100%, 40%);">- octetstring enc_key</span><br><span style="color: hsl(120, 100%, 40%);">+ octetstring enc_key,</span><br><span style="color: hsl(120, 100%, 40%);">+ octetstring enc_kc128 optional</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template (value) TestHdlrEncrParams t_EncrParams(OCT1 alg, octetstring key) := {</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) TestHdlrEncrParams t_EncrParams(OCT1 alg, octetstring key, template (omit) octetstring kc128 := omit) := {</span><br><span> enc_alg := alg,</span><br><span style="color: hsl(0, 100%, 40%);">- enc_key := key</span><br><span style="color: hsl(120, 100%, 40%);">+ enc_key := key,</span><br><span style="color: hsl(120, 100%, 40%);">+ enc_kc128 := kc128</span><br><span> }</span><br><span> </span><br><span> type record TestHdlrParamsLcls {</span><br><span>@@ -714,6 +716,7 @@</span><br><span> var PDU_BSSAP bssap;</span><br><span> var RSL_Message rsl;</span><br><span> var RSL_AlgId alg_rsl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring expect_kc;</span><br><span> </span><br><span> if (isvalue(enc.enc_kc128)) {</span><br><span> BSSAP.send(ts_BSSMAP_CipherModeCmdKc128(enc.enc_alg, enc.enc_key, valueof(enc.enc_kc128)));</span><br><span>@@ -725,9 +728,16 @@</span><br><span> * so we need to convert first */</span><br><span> alg_rsl := f_chipher_mode_bssmap_to_rsl(enc.enc_alg);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (alg_rsl == RSL_ALG_ID_A5_4 and ispresent(enc.enc_kc128)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_kc := enc.enc_kc128;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_kc := enc.enc_key;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ log("for encryption algo ", alg_rsl, " expect kc = ", expect_kc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> alt {</span><br><span> /* RSL/UE Side */</span><br><span style="color: hsl(0, 100%, 40%);">- [] RSL.receive(tr_RSL_ENCR_CMD(g_chan_nr, ?, alg_rsl, key)) -> value rsl {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL.receive(tr_RSL_ENCR_CMD(g_chan_nr, ?, alg_rsl, expect_kc)) -> value rsl {</span><br><span> var PDU_ML3_NW_MS l3 := dec_PDU_ML3_NW_MS(rsl.ies[3].body.l3_info.payload);</span><br><span> log("Rx L3 from net: ", l3);</span><br><span> if (ischosen(l3.msgs.rrm.cipheringModeCommand)) {</span><br><span>@@ -838,8 +848,15 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Missing Encryption IE in CHAN ACT");</span><br><span> } else {</span><br><span> var RSL_AlgId alg := f_chipher_mode_bssmap_to_rsl(g_pars.encr.enc_alg);</span><br><span style="color: hsl(0, 100%, 40%);">- if (not match(encr_info, tr_EncrInfo(alg, g_pars.encr.enc_key))) {</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Wrong Encryption IE in CHAN ACT");</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring expect_key;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (alg == RSL_ALG_ID_A5_4) {</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_key := g_pars.encr.enc_kc128;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_key := g_pars.encr.enc_key;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(encr_info, tr_EncrInfo(alg, expect_key))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Unexpected Kc in Encryption IE in RSL ENCR CMD");</span><br><span> }</span><br><span> }</span><br><span> } else {</span><br><span>diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg</span><br><span>index b64a63d..7b0fa2a 100644</span><br><span>--- a/bsc/osmo-bsc.cfg</span><br><span>+++ b/bsc/osmo-bsc.cfg</span><br><span>@@ -69,7 +69,7 @@</span><br><span> network</span><br><span> network country code 1</span><br><span> mobile network code 1</span><br><span style="color: hsl(0, 100%, 40%);">- encryption a5 0 1 3</span><br><span style="color: hsl(120, 100%, 40%);">+ encryption a5 0 1 3 4</span><br><span> neci 1</span><br><span> paging any use tch 0</span><br><span> handover 1</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669">change 24669</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifa48a8498dde7d04fb29f497013bdb5a1e5f3597 </div>
<div style="display:none"> Gerrit-Change-Number: 24669 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>