<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24394">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic loop simplification in gsm48_multirate_config()<br><br>Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe<br>---<br>M src/osmo-bsc/gsm_04_08_rr.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>index a641b45..16fe999 100644</span><br><span>--- a/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>+++ b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>@@ -417,13 +417,13 @@</span><br><span>      uint8_t *data;</span><br><span> </span><br><span>   /* Check if modes for consistency (order and duplicates) */</span><br><span style="color: hsl(0, 100%, 40%);">-     for (i = 0; i < num_modes; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-            if (i > 0 && modes[i - 1].mode > modes[i].mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+       for (i = 1; i < num_modes; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+          if (modes[i - 1].mode > modes[i].mode) {</span><br><span>                  LOGP(DRR, LOGL_ERROR,</span><br><span>                             "BUG: Multirate codec with inconsistent config (mode order).\n");</span><br><span>                     return -EINVAL;</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (i > 0 && modes[i - 1].mode == modes[i].mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (modes[i - 1].mode == modes[i].mode) {</span><br><span>                    LOGP(DRR, LOGL_ERROR,</span><br><span>                             "BUG: Multirate codec with inconsistent config (duplicate modes).\n");</span><br><span>                        return -EINVAL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24394">change 24394</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24394"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe </div>
<div style="display:none"> Gerrit-Change-Number: 24394 </div>
<div style="display:none"> Gerrit-PatchSet: 25 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>