<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24384">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">clarify bts_chan_load<br><br>Change-Id: I9bd80a08472018e69360ac5739979c7056d4f063<br>---<br>M src/osmo-bsc/chan_alloc.c<br>1 file changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c</span><br><span>index 5915a93..f2a41b7 100644</span><br><span>--- a/src/osmo-bsc/chan_alloc.c</span><br><span>+++ b/src/osmo-bsc/chan_alloc.c</span><br><span>@@ -59,18 +59,17 @@</span><br><span>                     if (!nm_is_running(&ts->mo.nm_state))</span><br><span>                                 continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                   /* Dynamic timeslots have to be counted separately</span><br><span style="color: hsl(0, 100%, 40%);">-                       * when not in TCH/F or TCH/H mode because they don't</span><br><span style="color: hsl(0, 100%, 40%);">-                        * have an lchan's allocated to them. At the same time,</span><br><span style="color: hsl(0, 100%, 40%);">-                      * dynamic timeslots in NONE and PDCH modes are same</span><br><span style="color: hsl(0, 100%, 40%);">-                     * as in UNUSED mode from the CS channel load perspective</span><br><span style="color: hsl(0, 100%, 40%);">-                        * beause they can be switched to TCH mode at any moment.</span><br><span style="color: hsl(0, 100%, 40%);">-                        * I.e. they are "available" for TCH. */</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* A dynamic timeslot currently in PDCH mode are available as TCH, beause they can be switched</span><br><span style="color: hsl(120, 100%, 40%);">+                         * to TCH mode at any moment. Count TCH/F_TCH/H_PDCH as one total timeslot, even though it may</span><br><span style="color: hsl(120, 100%, 40%);">+                         * be switched to TCH/H and would then count as two -- hence opt for pessimistic load. */</span><br><span>                    if ((ts->pchan_on_init == GSM_PCHAN_TCH_F_TCH_H_PDCH ||</span><br><span>                        ts->pchan_on_init == GSM_PCHAN_TCH_F_PDCH) &&</span><br><span>                            (ts->pchan_is == GSM_PCHAN_NONE ||</span><br><span>                         ts->pchan_is == GSM_PCHAN_PDCH)) {</span><br><span>                           pl->total++;</span><br><span style="color: hsl(120, 100%, 40%);">+                               /* Below loop would not count this timeslot, since in PDCH mode it has no usable</span><br><span style="color: hsl(120, 100%, 40%);">+                               * timeslots. But let's make it clear that the timeslot must not be counted again: */</span><br><span style="color: hsl(120, 100%, 40%);">+                             continue;</span><br><span>                    }</span><br><span> </span><br><span>                        ts_for_n_lchans(lchan, ts, ts->max_primary_lchans) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24384">change 24384</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24384"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9bd80a08472018e69360ac5739979c7056d4f063 </div>
<div style="display:none"> Gerrit-Change-Number: 24384 </div>
<div style="display:none"> Gerrit-PatchSet: 29 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>