<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24611">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_data.h: add comments about immutable activ/modif/assign request info<br><br>Change-Id: I7997b802d997073ae6a05db2f40e82cb8e83764f<br>---<br>M include/osmocom/bsc/gsm_data.h<br>1 file changed, 18 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/24611/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index dccf5a1..d3d5b7d 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -177,7 +177,13 @@</span><br><span>  * currently used lchan and gscon unmodified until the outcome of an Assignment is known. If the Assignment fails, this</span><br><span>  * state is simply discarded, and the gscon carries on with the original lchan remaining unchanged. */</span><br><span> struct assignment_fsm_data {</span><br><span style="color: hsl(120, 100%, 40%);">+   /* The request as made by the caller, see GSCON_EV_ASSIGNMENT_START or reassignment_request_to_lchan() /</span><br><span style="color: hsl(120, 100%, 40%);">+       * reassignment_request_to_chan_type().</span><br><span style="color: hsl(120, 100%, 40%);">+        * conn->assignment.req is treated immutable: remains unchanged throughout the Assignment. The mutable fields</span><br><span style="color: hsl(120, 100%, 40%);">+       * are below: choices and automatic adjustments are stored in conn->assignment.*, not conn->assignment.req.</span><br><span style="color: hsl(120, 100%, 40%);">+      */</span><br><span>  struct assignment_request req;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     bool requires_voice_stream;</span><br><span>  struct channel_mode_and_rate selected_ch_mode_rate;</span><br><span> </span><br><span>@@ -647,7 +653,13 @@</span><br><span>       struct osmo_mgcpc_ep_ci *mgw_endpoint_ci_bts;</span><br><span> </span><br><span>    struct {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* The request as made by the caller, see lchan_activate().</span><br><span style="color: hsl(120, 100%, 40%);">+            * lchan->activate.info is treated immutable: remains unchanged throughout the Activation.</span><br><span style="color: hsl(120, 100%, 40%);">+          * The mutable versions are below: some values need automatic adjustments, in which case they are copied</span><br><span style="color: hsl(120, 100%, 40%);">+               * from immutable lchan->activate.info.* to lchan->activate.*, for example lchan->activate.ch_mode_rate</span><br><span style="color: hsl(120, 100%, 40%);">+               * is initially a copy of lchan->activate.info.ch_mode_rate, and is possibly adjusted afterwards. */</span><br><span>              struct lchan_activate_info info;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>           struct channel_mode_and_rate ch_mode_rate;</span><br><span>           struct gsm48_multi_rate_conf mr_conf_filtered;</span><br><span>               bool activ_ack; /*< true as soon as RSL Chan Activ Ack is received */</span><br><span>@@ -662,7 +674,13 @@</span><br><span>      } activate;</span><br><span> </span><br><span>      struct {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* The request as made by the caller, see lchan_mode_modify().</span><br><span style="color: hsl(120, 100%, 40%);">+                 * lchan->modify.info is treated immutable: remains unchanged throughout the Mode Modify.</span><br><span style="color: hsl(120, 100%, 40%);">+           * The mutable versions are below: some values need automatic adjustments, in which case they are copied</span><br><span style="color: hsl(120, 100%, 40%);">+               * from immutable lchan->modify.info.* to lchan->modify.*, for example lchan->modify.ch_mode_rate</span><br><span style="color: hsl(120, 100%, 40%);">+             * is initially a copy of lchan->modify.info.ch_mode_rate, and is possibly adjusted afterwards. */</span><br><span>                struct lchan_modify_info info;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>             struct channel_mode_and_rate ch_mode_rate;</span><br><span>           struct gsm48_multi_rate_conf mr_conf_filtered;</span><br><span>               int tsc_set;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24611">change 24611</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24611"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7997b802d997073ae6a05db2f40e82cb8e83764f </div>
<div style="display:none"> Gerrit-Change-Number: 24611 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>