<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24604">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE<br><br>This function is called during the OML bootstrapping and when a<br>dynamic timeslot switches between PDCH and TCH/{F,H}.  In the<br>later case, while changing from TCH/{F,H} to PDCH, some lchans<br>would still have the old type assigned after this function.<br><br>Let's ensure that all logical channels are properly updated.<br><br>Change-Id: I44726f2bfb979c2fa2f5f30c5b11700cf4b3399d<br>Related: SYS#5313, OS#1569<br>---<br>M src/common/oml.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/24604/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 6acc6b1..8b84f85 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -826,6 +826,9 @@</span><br><span> int conf_lchans_as_pchan(struct gsm_bts_trx_ts *ts,</span><br><span>                       enum gsm_phys_chan_config pchan)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Initialize all lchans with GSM_LCHAN_NONE first */</span><br><span style="color: hsl(120, 100%, 40%);">+ lchans_type_set(ts, GSM_LCHAN_NONE, ARRAY_SIZE(ts->lchan));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     switch (pchan) {</span><br><span>     case GSM_PCHAN_CCCH_SDCCH4_CBCH:</span><br><span>     case GSM_PCHAN_CCCH_SDCCH4:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24604">change 24604</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24604"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I44726f2bfb979c2fa2f5f30c5b11700cf4b3399d </div>
<div style="display:none"> Gerrit-Change-Number: 24604 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>