<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24624">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">allow mode modify when RTP stream is active<br><br>Get rid of this artificial barrier, because Modify with active voice<br>stream is supported since commit<br>"lchan and assignment FSMs: make Channel Mode Modify more sane"<br>d5cb0eb8fda3ade89c7b2e23a626b68dfda96f46<br>I4986844f839b1c9672c61d916eb3d33d0042d747<br><br>Change-Id: I25f4a881fa32a07f97d7d6e6b812f8afc699d951<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 0 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/24624/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index c06735f..ded4129 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1111,15 +1111,6 @@</span><br><span>               return;</span><br><span> </span><br><span>  case LCHAN_EV_REQUEST_MODE_MODIFY:</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-              /* FIXME: Add missing implementation to handle an already existing RTP voice stream on MODE MODIFY.</span><br><span style="color: hsl(0, 100%, 40%);">-              * there may be transitions from VOICE to SIGNALLING and also from VOICE to VOICE with a different</span><br><span style="color: hsl(0, 100%, 40%);">-               * codec. */</span><br><span style="color: hsl(0, 100%, 40%);">-            if (lchan->fi_rtp) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 lchan_fail("MODE MODIFY not implemented when RTP voice stream is already active (VOICE => SIGNALLING, VOICE/CODEC_A => VOICE/CODEC_B)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                      return;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            modif_info = data;</span><br><span>           lchan->modify.info = *modif_info;</span><br><span>                 lchan->modify.concluded = false;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24624">change 24624</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24624"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I25f4a881fa32a07f97d7d6e6b812f8afc699d951 </div>
<div style="display:none"> Gerrit-Change-Number: 24624 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>