<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24398">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RAW_NS: add missing idx to as_rx_alive_tx_ack<br><br>Without the index the message got send and received<br>via the wrong NSVC.<br><br>Change-Id: Ic5d1f4aa5e8a2373a4f46feef44e71b9688035c9<br>---<br>M library/RAW_NS.ttcnpp<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp</span><br><span>index ff73348..93c43f0 100644</span><br><span>--- a/library/RAW_NS.ttcnpp</span><br><span>+++ b/library/RAW_NS.ttcnpp</span><br><span>@@ -100,7 +100,7 @@</span><br><span>     var default d := activate(ax_rx_fail_on_any_ns());</span><br><span>   alt {</span><br><span>        [] NSCP[idx].receive(PDU_NS: exp_rx) -> value nrf { }</span><br><span style="color: hsl(0, 100%, 40%);">-        [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  }</span><br><span>    deactivate(d);</span><br><span>       return nrf;</span><br><span>@@ -111,7 +111,7 @@</span><br><span>    NSCP[idx].send(t_NS_ALIVE);</span><br><span>  alt {</span><br><span>        [] NSCP[idx].receive(t_NS_ALIVE_ACK);</span><br><span style="color: hsl(0, 100%, 40%);">-   [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     }</span><br><span> }</span><br><span>@@ -125,7 +125,7 @@</span><br><span>         [] NSCP[idx].receive(t_NS_ALIVE_ACK) {</span><br><span>               setverdict(fail, "Received unexpected NS-ALIVE ACK");</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-       [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     [] T.timeout {</span><br><span>               setverdict(pass);</span><br><span>@@ -142,7 +142,7 @@</span><br><span>      [] NSCP[idx].receive(ts_NS_RESET_ACK(g_nsconfig.nsvc[idx].nsvci, g_nsconfig.nsei)) {</span><br><span>                 setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     [] T.timeout {</span><br><span>               setverdict(fail, "Failed to receive a RESET ACK");</span><br><span>@@ -155,7 +155,7 @@</span><br><span>   NSCP[idx].send(ts_NS_BLOCK(cause, g_nsconfig.nsvc[idx].nsvci));</span><br><span>      alt {</span><br><span>        [] NSCP[idx].receive(tr_NS_BLOCK_ACK(g_nsconfig.nsvc[idx].nsvci));</span><br><span style="color: hsl(0, 100%, 40%);">-      [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     }</span><br><span> }</span><br><span>@@ -165,7 +165,7 @@</span><br><span>         NSCP[idx].send(t_NS_UNBLOCK);</span><br><span>        alt {</span><br><span>        [] NSCP[idx].receive(t_NS_UNBLOCK_ACK);</span><br><span style="color: hsl(0, 100%, 40%);">- [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     }</span><br><span> }</span><br><span>@@ -205,7 +205,7 @@</span><br><span>         [not exp_ack] T.timeout {</span><br><span>            setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [g_handle_rx_alive] as_rx_alive_tx_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+     [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);</span><br><span>  [] NSCP[idx].receive { repeat; }</span><br><span>     }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24398">change 24398</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24398"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic5d1f4aa5e8a2373a4f46feef44e71b9688035c9 </div>
<div style="display:none"> Gerrit-Change-Number: 24398 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>