<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24416">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">f_ms_tx_data_ind(): indicate actual Timing Advance in DATA.ind<br><br>Change-Id: Id89a5ed1ea82a81f0ce4e75204117afb322f5264<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_selftest.ttcn<br>2 files changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 5cf9104..2297fb6 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -626,7 +626,7 @@</span><br><span> function f_ms_tx_data_ind(inout GprsMS ms, octetstring data, uint32_t fn := 0,</span><br><span>                       template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span> runs on MS_BTS_IFACE_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-       f_pcuif_tx_data_ind(data, ms.lqual_cb, fn, nr := nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuif_tx_data_ind(data, fn, ms.ta, ms.lqual_cb, nr := nr);</span><br><span> }</span><br><span> </span><br><span> function f_ms_tx_ul_block(inout GprsMS ms, template (value) RlcmacUlBlock ul_data,</span><br><span>@@ -1070,14 +1070,15 @@</span><br><span> }</span><br><span> </span><br><span> /* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_pcuif_tx_data_ind(octetstring data, int16_t lqual_cb := 0, uint32_t fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+function f_pcuif_tx_data_ind(octetstring data, uint32_t fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+                        TimingAdvance ta := 0, int16_t lqual_cb := 0,</span><br><span>                        template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span> runs on MS_BTS_IFACE_CT {</span><br><span>         var template RAW_PCU_EventParam ev_param := {tdma_fn := ? };</span><br><span>         BTS.send(ts_PCUIF_DATA_IND(nr.bts_nr, nr.trx_nr, nr.ts_nr, nr.blk_nr,</span><br><span>                                   sapi := PCU_IF_SAPI_PDTCH, data := data,</span><br><span>                             fn := fn, arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)),</span><br><span style="color: hsl(0, 100%, 40%);">-                                   lqual_cb := lqual_cb));</span><br><span style="color: hsl(120, 100%, 40%);">+                               ta_offs_qbits := ta * 4, lqual_cb := lqual_cb));</span><br><span>  if (fn != 0) {</span><br><span>               ev_param := {tdma_fn := fn };</span><br><span>        }</span><br><span>diff --git a/pcu/PCU_selftest.ttcn b/pcu/PCU_selftest.ttcn</span><br><span>index 70138bf..a8bcaee 100644</span><br><span>--- a/pcu/PCU_selftest.ttcn</span><br><span>+++ b/pcu/PCU_selftest.ttcn</span><br><span>@@ -291,7 +291,7 @@</span><br><span>             data := f_pad_oct(data, f_rlcmac_cs_mcs2block_len(schemes[i]), '00'O);</span><br><span> </span><br><span>           /* Send to PCU so that we get gsmtap traces to verify with wireshark */</span><br><span style="color: hsl(0, 100%, 40%);">-         f_pcuif_tx_data_ind(data, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_pcuif_tx_data_ind(data);</span><br><span> </span><br><span>               log("Decoding ", schemes[i]);</span><br><span>              ul_data := dec_RlcmacUlBlock(data);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24416">change 24416</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24416"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id89a5ed1ea82a81f0ce4e75204117afb322f5264 </div>
<div style="display:none"> Gerrit-Change-Number: 24416 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>