<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24515">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: fix NULL pointer dereference in trx_if_send_burst()<br><br>Starting from TRXDv2 [1], trx_if_send_burst() would keep batching<br>PDUs to the static buffer, unless it's called with br = NULL, so<br>we cannot dereference br in the logging statement.<br><br>Of course, we could also store TDMA frame number in a static<br>variable, but I don't think it's worth it just for logging.<br><br>Change-Id: I4a361777fc40bdedcebbe54df6274bc5573f77a8<br>Fixes: [1] I9b4cc8e10cd683b28d22e32890569484cd20372d<br>Fixes: CID#236232<br>---<br>M src/osmo-bts-trx/trx_if.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c</span><br><span>index c10a15f..afd630f 100644</span><br><span>--- a/src/osmo-bts-trx/trx_if.c</span><br><span>+++ b/src/osmo-bts-trx/trx_if.c</span><br><span>@@ -1154,8 +1154,8 @@</span><br><span> </span><br><span> sendall:</span><br><span>  LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-             "Tx TRXDv%u datagram with %u PDU(s): fn=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                pdu_ver, pdu_num, br->fn);</span><br><span style="color: hsl(120, 100%, 40%);">+         "Tx TRXDv%u datagram with %u PDU(s)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             pdu_ver, pdu_num);</span><br><span> </span><br><span>       /* TRXDv2: unset BATCH.ind in the last PDU */</span><br><span>        if (pdu_ver >= 2)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24515">change 24515</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24515"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4a361777fc40bdedcebbe54df6274bc5573f77a8 </div>
<div style="display:none"> Gerrit-Change-Number: 24515 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>