<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24483">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[VAMOS] l1sap: get_lchan_by_chan_nr() may return NULL<br><br>Change-Id: Ic309622d0ee818302dfc66d69fd2914ae28261d6<br>---<br>M src/common/l1sap.c<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index a47f653..b0cffe5 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -765,6 +765,12 @@</span><br><span>      struct info_act_cnf_param *info_act_cnf)</span><br><span> {</span><br><span>        struct gsm_lchan *lchan = get_lchan_by_chan_nr(trx, info_act_cnf->chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (lchan == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPTRX(trx, DL1C, LOGL_ERROR, "get_lchan_by_chan_nr(chan_nr=%s) "</span><br><span style="color: hsl(120, 100%, 40%);">+                  "yields NULL for PRIM_INFO_ACTIVATE.conf\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        rsl_chan_nr_str(info_act_cnf->chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+           return -ENODEV;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        LOGPLCHAN(lchan, DL1C, LOGL_INFO, "activate confirm chan_nr=%s trx=%d\n",</span><br><span>            rsl_chan_nr_str(info_act_cnf->chan_nr), trx->nr);</span><br><span>@@ -788,6 +794,12 @@</span><br><span>     struct info_act_cnf_param *info_act_cnf)</span><br><span> {</span><br><span>        struct gsm_lchan *lchan = get_lchan_by_chan_nr(trx, info_act_cnf->chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (lchan == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPTRX(trx, DL1C, LOGL_ERROR, "get_lchan_by_chan_nr(chan_nr=%s) "</span><br><span style="color: hsl(120, 100%, 40%);">+                  "yields NULL for PRIM_INFO_ACTIVATE.conf\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        rsl_chan_nr_str(info_act_cnf->chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+           return -ENODEV;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        LOGPLCHAN(lchan, DL1C, LOGL_INFO, "deactivate confirm chan_nr=%s trx=%d\n",</span><br><span>                  rsl_chan_nr_str(info_act_cnf->chan_nr), trx->nr);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24483">change 24483</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24483"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic309622d0ee818302dfc66d69fd2914ae28261d6 </div>
<div style="display:none"> Gerrit-Change-Number: 24483 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>