<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24527">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: remove over-defensive checks in is_meas_complete()<br><br>The timeslot number ts->nr is set in gsm_bts_trx_alloc() and can<br>never be greater than 7.  Regarding the physical channel type<br>returned by ts_pchan(), it's also unlikely to be greater than<br>_GSM_PCHAN_MAX.<br><br>Change-Id: I6d20d7cba49cc8b6d1dc2192598ca372b7d2c5bf<br>---<br>M src/common/measurement.c<br>1 file changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/24527/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 03afaa3..b586987 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -250,11 +250,6 @@</span><br><span>   int rc = 0;</span><br><span>  enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (lchan->ts->nr >= 8)</span><br><span style="color: hsl(0, 100%, 40%);">-                return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">- if (pchan >= _GSM_PCHAN_MAX)</span><br><span style="color: hsl(0, 100%, 40%);">-         return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      switch (pchan) {</span><br><span>     case GSM_PCHAN_TCH_F:</span><br><span>                fn_mod = translate_tch_meas_rep_fn104(fn % 104);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24527">change 24527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6d20d7cba49cc8b6d1dc2192598ca372b7d2c5bf </div>
<div style="display:none"> Gerrit-Change-Number: 24527 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>