<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24537">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware: octsimtest: use TRACE_* macros instead of direct printf<br><br>Change-Id: I41864bc2f64905a4f2ccb50769b1840e8a490c76<br>---<br>M firmware/libboard/octsimtest/source/mcp23017.c<br>M firmware/libboard/octsimtest/source/mux.c<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/37/24537/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/octsimtest/source/mcp23017.c b/firmware/libboard/octsimtest/source/mcp23017.c</span><br><span>index bc6bd49..959f2c6 100644</span><br><span>--- a/firmware/libboard/octsimtest/source/mcp23017.c</span><br><span>+++ b/firmware/libboard/octsimtest/source/mcp23017.c</span><br><span>@@ -94,7 +94,7 @@</span><br><span> </span><br><span> int mcp23017_init(uint8_t slave, uint8_t iodira, uint8_t iodirb)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      printf("mcp23017_init\n\r");</span><br><span style="color: hsl(120, 100%, 40%);">+        TRACE_DEBUG("mcp23017_init\n\r");</span><br><span> </span><br><span>      // all gpio input</span><br><span>    if (mcp23017_write_byte(slave, MCP23017_IODIRA, iodira))</span><br><span>@@ -105,11 +105,11 @@</span><br><span>     if (mcp23017_write_byte(slave, MCP23017_IOCONA, 0x20)) //disable SEQOP (autoinc addressing)</span><br><span>          goto out_err;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       printf("mcp23017 found\n\r");</span><br><span style="color: hsl(120, 100%, 40%);">+       TRACE_DEBUG("mcp23017 found\n\r");</span><br><span>         return 0;</span><br><span> </span><br><span> out_err:</span><br><span style="color: hsl(0, 100%, 40%);">-       printf("mcp23017 NOT found!\n\r");</span><br><span style="color: hsl(120, 100%, 40%);">+  TRACE_WARNING("mcp23017 NOT found!\n\r");</span><br><span>  return -1;</span><br><span> }</span><br><span> </span><br><span>diff --git a/firmware/libboard/octsimtest/source/mux.c b/firmware/libboard/octsimtest/source/mux.c</span><br><span>index 54c6cb6..8800ba2 100644</span><br><span>--- a/firmware/libboard/octsimtest/source/mux.c</span><br><span>+++ b/firmware/libboard/octsimtest/source/mux.c</span><br><span>@@ -54,7 +54,7 @@</span><br><span> /* set the slot selection mux */</span><br><span> int mux_set_slot(uint8_t s)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        printf("%s(%u)\r\n", __func__, s);</span><br><span style="color: hsl(120, 100%, 40%);">+  TRACE_INFO("%s(%u)\r\n", __func__, s);</span><br><span> </span><br><span>         if (s > 7)</span><br><span>                return -EINVAL;</span><br><span>@@ -90,7 +90,7 @@</span><br><span> /* set the frequency divider mux */</span><br><span> void mux_set_freq(uint8_t s)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("%s(%u)\r\n", __func__, s);</span><br><span style="color: hsl(120, 100%, 40%);">+  TRACE_INFO("%s(%u)\r\n", __func__, s);</span><br><span> </span><br><span>         /* no need for 'break before make' here, this would also affect</span><br><span>       * the SIM card I/O signals which we don't want to disturb */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/24537">change 24537</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/24537"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I41864bc2f64905a4f2ccb50769b1840e8a490c76 </div>
<div style="display:none"> Gerrit-Change-Number: 24537 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>