<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24538">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware: octsimtest: Fix disabling the card_insert signal<br><br>Back in I8c9b0c3d862a967832134b24252577739182da62 we added support<br>for enabling the card_insert signal, but not for explicit disable<br>of it.  Let's fix that.<br><br>Change-Id: I6f32bde60674119c9912e51059a53b5ee74d074a<br>---<br>M firmware/libboard/octsimtest/source/board_octsimtest.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/38/24538/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c</span><br><span>index 1c6a278..5dff046 100644</span><br><span>--- a/firmware/libboard/octsimtest/source/board_octsimtest.c</span><br><span>+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c</span><br><span>@@ -103,8 +103,13 @@</span><br><span>     * the sim-present signal of the respective slot */</span><br><span> </span><br><span>      if (mcp2317_present) {</span><br><span style="color: hsl(0, 100%, 40%);">-          /* we must enable card-presence of the active slot and disable it on all others */</span><br><span style="color: hsl(0, 100%, 40%);">-              mcp23017_set_output_a(MCP23017_ADDRESS, (1 << s));</span><br><span style="color: hsl(120, 100%, 40%);">+              if (card_insert) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* we must enable card-presence of the active slot and disable it on all others */</span><br><span style="color: hsl(120, 100%, 40%);">+                    mcp23017_set_output_a(MCP23017_ADDRESS, (1 << s));</span><br><span style="color: hsl(120, 100%, 40%);">+              } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      /* we disable all card insert signals */</span><br><span style="color: hsl(120, 100%, 40%);">+                      mcp23017_set_output_a(MCP23017_ADDRESS, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>    } else {</span><br><span>             TRACE_WARNING("No MCP23017 present; cannot set CARD_INSERT\r\n");</span><br><span>  }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/24538">change 24538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/24538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f32bde60674119c9912e51059a53b5ee74d074a </div>
<div style="display:none"> Gerrit-Change-Number: 24538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>