<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24517">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix rc handling in channel_mode_from_lchan()<br><br>chan_mode_to_rsl_cmod_spd may actually return negative on error. To be<br>able to check for that, handle the returned value as a signed rc before<br>assigning to the unsigned spd_ind.<br><br>Related: SYS#5315 OS#4940 CID#236231<br>Change-Id: I52e13b24ce67e288ff32dbdaa1c1759089926f5c<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/24517/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 9378ecb..1fb4c04 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -354,6 +354,7 @@</span><br><span>                              struct gsm_lchan *lchan,</span><br><span>                             const struct channel_mode_and_rate *ch_mode_rate)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     int rc;</span><br><span>      memset(cm, 0, sizeof(*cm));</span><br><span> </span><br><span>      /* FIXME: what to do with data calls ? */</span><br><span>@@ -364,11 +365,12 @@</span><br><span>            cm->dtx_dtu |= RSL_CMOD_DTXd;</span><br><span> </span><br><span>         /* set TCH Speech/Data */</span><br><span style="color: hsl(0, 100%, 40%);">-       cm->spd_ind = chan_mode_to_rsl_cmod_spd(ch_mode_rate->chan_mode);</span><br><span style="color: hsl(0, 100%, 40%);">- if (cm->spd_ind < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+  rc = chan_mode_to_rsl_cmod_spd(ch_mode_rate->chan_mode);</span><br><span style="color: hsl(120, 100%, 40%);">+   if (rc < 0) {</span><br><span>             LOGP(DRSL, LOGL_ERROR, "unsupported: chan_mode = 0x%02x\n", ch_mode_rate->chan_mode);</span><br><span style="color: hsl(0, 100%, 40%);">-              return cm->spd_ind;</span><br><span style="color: hsl(120, 100%, 40%);">+                return rc;</span><br><span>   }</span><br><span style="color: hsl(120, 100%, 40%);">+     cm->spd_ind = rc;</span><br><span> </span><br><span>     switch (lchan->type) {</span><br><span>    case GSM_LCHAN_SDCCH:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24517">change 24517</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24517"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I52e13b24ce67e288ff32dbdaa1c1759089926f5c </div>
<div style="display:none"> Gerrit-Change-Number: 24517 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>