<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24510">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assert: Use printf_sync() to ensure printing of assert / panic<br><br>Change-Id: Icc202e60445d9be1cdcd61176db5ed1704d583e7<br>---<br>M firmware/libcommon/include/assert.h<br>M firmware/libosmocore/source/panic.c<br>M firmware/test/card_emu_tests.c<br>3 files changed, 16 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/10/24510/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/include/assert.h b/firmware/libcommon/include/assert.h</span><br><span>index 22bb101..dc6b1b5 100644</span><br><span>--- a/firmware/libcommon/include/assert.h</span><br><span>+++ b/firmware/libcommon/include/assert.h</span><br><span>@@ -89,7 +89,7 @@</span><br><span>             /// \param condition  Condition to verify.</span><br><span>           #define ASSERT(condition)  { \</span><br><span>                       if (!(condition)) { \</span><br><span style="color: hsl(0, 100%, 40%);">-                           printf("-F- ASSERT: %s %s:%d\n\r", #condition, __BASE_FILE__, __LINE__); \</span><br><span style="color: hsl(120, 100%, 40%);">+                          printf_sync("-F- ASSERT: %s %s:%d\n\r", #condition, __BASE_FILE__, __LINE__); \</span><br><span>                            while (1); \</span><br><span>                         } \</span><br><span>          }</span><br><span>diff --git a/firmware/libosmocore/source/panic.c b/firmware/libosmocore/source/panic.c</span><br><span>index 74243b0..db5c26a 100644</span><br><span>--- a/firmware/libosmocore/source/panic.c</span><br><span>+++ b/firmware/libosmocore/source/panic.c</span><br><span>@@ -46,7 +46,7 @@</span><br><span> __attribute__ ((format (printf, 1, 0)))</span><br><span> static void osmo_panic_default(const char *fmt, va_list args)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- vfprintf(stderr, fmt, args);</span><br><span style="color: hsl(120, 100%, 40%);">+  vfprintf_sync(stderr, fmt, args);</span><br><span>    osmo_generate_backtrace();</span><br><span>   assert(0);</span><br><span> }</span><br><span>diff --git a/firmware/test/card_emu_tests.c b/firmware/test/card_emu_tests.c</span><br><span>index 69159a8..5d5bd3e 100644</span><br><span>--- a/firmware/test/card_emu_tests.c</span><br><span>+++ b/firmware/test/card_emu_tests.c</span><br><span>@@ -13,6 +13,20 @@</span><br><span> #define PHONE_INT  2</span><br><span> #define PHONE_DATAOUT      3</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* stub for stdio */</span><br><span style="color: hsl(120, 100%, 40%);">+signed int printf_sync(const char *pFormat, ...)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      va_list ap;</span><br><span style="color: hsl(120, 100%, 40%);">+   signed int result;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  va_start(ap, pFormat);</span><br><span style="color: hsl(120, 100%, 40%);">+        result = vprintf(pFormat, ap);</span><br><span style="color: hsl(120, 100%, 40%);">+        va_end(ap);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return result;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span>  * stub functions required by card_emu.c</span><br><span>  ***********************************************************************/</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/24510">change 24510</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/24510"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc202e60445d9be1cdcd61176db5ed1704d583e7 </div>
<div style="display:none"> Gerrit-Change-Number: 24510 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>