<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24488">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SIP re-INVITE: log media connection<br><br>Change-Id: I2d11be9fe65aa76e044a91f88ba0e9a1d8e756ec<br>---<br>M src/sip.c<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index 93ae69c..f0bc4c3 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -214,8 +214,8 @@</span><br><span> }</span><br><span> </span><br><span> LOGP(DSIP, LOGL_DEBUG, "pre re-INVITE have IP:port (%s:%u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_sockaddr_ntop((struct sockaddr*)&leg->base.addr, ip_addr),</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_sockaddr_port((struct sockaddr*)&leg->base.addr));</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_ntop((struct sockaddr*)&prev_addr, ip_addr),</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_port((struct sockaddr*)&prev_addr));</span><br><span> </span><br><span> if (mode == sdp_sendonly) {</span><br><span> /* SIP side places call on HOLD */</span><br><span>@@ -235,9 +235,15 @@</span><br><span> osmo_sockaddr_port((struct sockaddr*)&leg->base.addr));</span><br><span> if (osmo_sockaddr_cmp((struct osmo_sockaddr *)&prev_addr,</span><br><span> (struct osmo_sockaddr *)&leg->base.addr)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DSIP, LOGL_INFO, "re-INVITE changes media connection.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DSIP, LOGL_INFO, "re-INVITE changes media connection to %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_ntop((struct sockaddr*)&leg->base.addr, ip_addr),</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_port((struct sockaddr*)&leg->base.addr));</span><br><span> if (other->update_rtp)</span><br><span> other->update_rtp(leg->base.call->remote);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DSIP, LOGL_INFO, "re-INVITE does not change media connection (%s:%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_ntop((struct sockaddr*)&prev_addr, ip_addr),</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sockaddr_port((struct sockaddr*)&prev_addr));</span><br><span> }</span><br><span> sdp = sdp_create_file(leg, other, sdp_sendrecv);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24488">change 24488</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24488"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2d11be9fe65aa76e044a91f88ba0e9a1d8e756ec </div>
<div style="display:none"> Gerrit-Change-Number: 24488 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>