<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24474">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix use-after-free in SIP re-INVITE<br><br>Copy the m_mode before freeing the parser.<br>Address sanitizer aborted with:<br><br>20210601033017695 DSIP INFO re-INVITE for call 854A5CDA8037073 (sip.c:192)<br>=================================================================<br>==8583==ERROR: AddressSanitizer: heap-use-after-free on address 0x612000003250 at pc 0x55c3b4624dc5 bp 0x7ffe8a4464d0 sp 0x7ffe8a4464c8<br>READ of size 8 at 0x612000003250 thread T0<br>    #0 0x55c3b4624dc4 in sdp_get_sdp_mode ../../../src/osmo-sip-connector/src/sdp.c:72<br>    #1 0x55c3b462be9e in sip_handle_reinvite ../../../src/osmo-sip-connector/src/sip.c:202<br>    #2 0x55c3b462d676 in nua_callback ../../../src/osmo-sip-connector/src/sip.c:397<br>[...]<br><br>Change-Id: I4c48832f01e61e98536de8f164ab5a3caa64f34a<br>---<br>M src/sdp.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/74/24474/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sdp.c b/src/sdp.c</span><br><span>index f1909d4..7bfcff5 100644</span><br><span>--- a/src/sdp.c</span><br><span>+++ b/src/sdp.c</span><br><span>@@ -68,8 +68,8 @@</span><br><span>          return sdp_sendrecv;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   sdp_parser_free(parser);</span><br><span>     *mode = sdp->sdp_media->m_mode;</span><br><span style="color: hsl(120, 100%, 40%);">+ sdp_parser_free(parser);</span><br><span>     return true;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24474">change 24474</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24474"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4c48832f01e61e98536de8f164ab5a3caa64f34a </div>
<div style="display:none"> Gerrit-Change-Number: 24474 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>