<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24427">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">meas rep logging: use log_check_level() to skip a logging loop<br><br>A side effect is that the final cleanup part of that function is now<br>always called, also when num_cell == 7.<br><br>(Whether we should really clear that logging context at that place is a<br>different question, out of scope here.)<br><br>Change-Id: I71a402a0940857bbedbaf25d293429934706a83c<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 7 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/24427/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 17e754d..6d9dfe1 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1080,12 +1080,13 @@</span><br><span> </span><br><span>         DEBUGP(DMEAS, "%s\n", print_meas_rep_c(OTC_SELECT, lchan, mr));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (mr->num_cell == 7)</span><br><span style="color: hsl(0, 100%, 40%);">-               return;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < mr->num_cell; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-              struct gsm_meas_rep_cell *mrc = &mr->cell[i];</span><br><span style="color: hsl(0, 100%, 40%);">-            DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                      mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev));</span><br><span style="color: hsl(120, 100%, 40%);">+     if (mr->num_cell != 7</span><br><span style="color: hsl(120, 100%, 40%);">+          && log_check_level(DMEAS, LOGL_DEBUG)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          for (i = 0; i < mr->num_cell; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    struct gsm_meas_rep_cell *mrc = &mr->cell[i];</span><br><span style="color: hsl(120, 100%, 40%);">+                  DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                            mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev));</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>    }</span><br><span> </span><br><span>        if (bsub)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24427">change 24427</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24427"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I71a402a0940857bbedbaf25d293429934706a83c </div>
<div style="display:none"> Gerrit-Change-Number: 24427 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>