<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24421">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add FIXME comments around bs_power<br><br>Change-Id: I229db1d6bcf532af95aff56b2ad18b5ed9d81616<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/abis_rsl.c<br>2 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/24421/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 5a202bf..91cb0e0 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -665,6 +665,8 @@</span><br><span>   enum gsm48_chan_mode tch_mode;</span><br><span>       enum lchan_csd_mode csd_mode;</span><br><span>        /* Power levels for MS and BTS */</span><br><span style="color: hsl(120, 100%, 40%);">+     /* FIXME: these are stored as dB/2 as encoded on the wire. For logging and VTY output as well as dB</span><br><span style="color: hsl(120, 100%, 40%);">+    * calculations, these values should probably be stored as plain dB values here. */</span><br><span>  uint8_t bs_power;</span><br><span>    uint8_t ms_power;</span><br><span>    /* Encryption information */</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index eb30345..a01a78a 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -307,9 +307,14 @@</span><br><span> </span><br><span>     msg = rsl_msgb_alloc();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* FIXME: this function is weird in that it takes the db arg as an input to write to a msgb, but it also</span><br><span style="color: hsl(120, 100%, 40%);">+       * modifies lchan->bs_power. Probably the caller should first set lchan->bs_power and then this function should</span><br><span style="color: hsl(120, 100%, 40%);">+  * merely write lchan->bs_power to the msgb.</span><br><span style="color: hsl(120, 100%, 40%);">+        */</span><br><span>  lchan->bs_power = db/2;</span><br><span>   if (fpc)</span><br><span>             lchan->bs_power |= 0x10;</span><br><span style="color: hsl(120, 100%, 40%);">+           /* FIXME: This is insane! the Fast Power Control bit should never be written to lchan->bs_power! */</span><br><span> </span><br><span>   dh = (struct abis_rsl_dchan_hdr *) msgb_put(msg, sizeof(*dh));</span><br><span>       init_dchan_hdr(dh, RSL_MT_BS_POWER_CONTROL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24421">change 24421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I229db1d6bcf532af95aff56b2ad18b5ed9d81616 </div>
<div style="display:none"> Gerrit-Change-Number: 24421 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>