<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24344">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">commands: remove superfluous getter/setter for cla_byte property<br><br>There's little point in having a getter+setter for a property if<br>all it does is assigning a value to an attribute of self.  That<br>works without any property methods<br><br>Change-Id: Id214cc83a29e8aa88f4e1413e07b419285c1b7ff<br>---<br>M pySim/commands.py<br>1 file changed, 1 insertion(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/44/24344/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/commands.py b/pySim/commands.py</span><br><span>index 81d8563..f87e743 100644</span><br><span>--- a/pySim/commands.py</span><br><span>+++ b/pySim/commands.py</span><br><span>@@ -29,7 +29,7 @@</span><br><span> class SimCardCommands(object):</span><br><span>  def __init__(self, transport):</span><br><span>               self._tp = transport</span><br><span style="color: hsl(0, 100%, 40%);">-            self._cla_byte = "a0"</span><br><span style="color: hsl(120, 100%, 40%);">+               self.cla_byte = "a0"</span><br><span>               self.sel_ctrl = "0000"</span><br><span> </span><br><span>         # Extract a single FCP item from TLV</span><br><span>@@ -89,13 +89,6 @@</span><br><span>            """Return the ATR of the currently inserted card."""</span><br><span>           return self._tp.get_atr()</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   @property</span><br><span style="color: hsl(0, 100%, 40%);">-       def cla_byte(self):</span><br><span style="color: hsl(0, 100%, 40%);">-             return self._cla_byte</span><br><span style="color: hsl(0, 100%, 40%);">-   @cla_byte.setter</span><br><span style="color: hsl(0, 100%, 40%);">-        def cla_byte(self, value):</span><br><span style="color: hsl(0, 100%, 40%);">-              self._cla_byte = value</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       def try_select_path(self, dir_list):</span><br><span>                 """ Try to select a specified path given as list of hex-string FIDs"""</span><br><span>                 rv = []</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24344">change 24344</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24344"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id214cc83a29e8aa88f4e1413e07b419285c1b7ff </div>
<div style="display:none"> Gerrit-Change-Number: 24344 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>