<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24288">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common: phy_links_open(): warn about dangling PHY instances<br><br>Change-Id: I8d84bf7a00da6b985cb3dc314e86cacac8d4f48c<br>---<br>M src/common/phy_link.c<br>1 file changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/phy_link.c b/src/common/phy_link.c</span><br><span>index 93c6f2c..7743c22 100644</span><br><span>--- a/src/common/phy_link.c</span><br><span>+++ b/src/common/phy_link.c</span><br><span>@@ -154,11 +154,20 @@</span><br><span> </span><br><span> int phy_links_open(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     const struct phy_instance *pinst;</span><br><span>    struct phy_link *plink;</span><br><span> </span><br><span>  llist_for_each_entry(plink, &g_phy_links, list) {</span><br><span>                int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+           /* Warn about dangling PHY instances */</span><br><span style="color: hsl(120, 100%, 40%);">+               llist_for_each_entry(pinst, &plink->instances, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (pinst->trx != NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+                            continue;</span><br><span style="color: hsl(120, 100%, 40%);">+                     LOGPPHI(pinst, DL1C, LOGL_NOTICE, "This PHY instance is not associated "</span><br><span style="color: hsl(120, 100%, 40%);">+                            "with a TRX instance, check the configuration file!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          rc = bts_model_phy_link_open(plink);</span><br><span>                 if (rc < 0)</span><br><span>                       return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24288">change 24288</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24288"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8d84bf7a00da6b985cb3dc314e86cacac8d4f48c </div>
<div style="display:none"> Gerrit-Change-Number: 24288 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>