<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24268">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Clean up TS selection in ipaccess_sign_link_up/down<br><br>Change-Id: I3e60ebc979010830a5c40112824893a640c58fd4<br>---<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>index 16fa201..7fb7948 100644</span><br><span>--- a/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>@@ -678,10 +678,11 @@</span><br><span>      struct e1inp_sign_link *sign_link = NULL;</span><br><span>    struct timespec tp;</span><br><span>  int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+       struct e1inp_ts *sign_ts = e1inp_line_ipa_oml_ts(line);</span><br><span> </span><br><span>  bts = find_bts_by_unitid(bsc_gsmnet, dev->site_id, dev->bts_id);</span><br><span>       if (!bts) {</span><br><span style="color: hsl(0, 100%, 40%);">-             ipaccess_sign_link_reject(dev, &line->ts[E1INP_SIGN_OML - 1]);</span><br><span style="color: hsl(120, 100%, 40%);">+         ipaccess_sign_link_reject(dev, sign_ts);</span><br><span>             return NULL;</span><br><span>         }</span><br><span>    DEBUGP(DLINP, "%s: Identified BTS %u/%u/%u\n", e1inp_signtype_name(type),</span><br><span>@@ -701,7 +702,7 @@</span><br><span> </span><br><span>                /* create new OML link. */</span><br><span>           sign_link = bts->oml_link =</span><br><span style="color: hsl(0, 100%, 40%);">-                  e1inp_sign_link_create(&line->ts[E1INP_SIGN_OML - 1],</span><br><span style="color: hsl(120, 100%, 40%);">+                  e1inp_sign_link_create(sign_ts,</span><br><span>                                              E1INP_SIGN_OML, bts->c0,</span><br><span>                                          bts->oml_tei, 0);</span><br><span>                 rc = clock_gettime(CLOCK_MONOTONIC, &tp);</span><br><span>@@ -726,7 +727,7 @@</span><br><span> </span><br><span>              /* set new RSL link for this TRX. */</span><br><span>                 line = bts->oml_link->ts->line;</span><br><span style="color: hsl(0, 100%, 40%);">-                ts = &line->ts[E1INP_SIGN_RSL + dev->trx_id - 1];</span><br><span style="color: hsl(120, 100%, 40%);">+           ts = e1inp_line_ipa_rsl_ts(line, dev->trx_id);</span><br><span>            e1inp_ts_config_sign(ts, line);</span><br><span>              sign_link = trx->rsl_link =</span><br><span>                               e1inp_sign_link_create(ts, E1INP_SIGN_RSL,</span><br><span>@@ -751,7 +752,7 @@</span><br><span> static void ipaccess_sign_link_down(struct e1inp_line *line)</span><br><span> {</span><br><span>        /* No matter what link went down, we close both signal links. */</span><br><span style="color: hsl(0, 100%, 40%);">-        struct e1inp_ts *ts = &line->ts[E1INP_SIGN_OML-1];</span><br><span style="color: hsl(120, 100%, 40%);">+     struct e1inp_ts *ts = e1inp_line_ipa_oml_ts(line);</span><br><span>   struct gsm_bts *bts = NULL;</span><br><span>  struct e1inp_sign_link *link;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24268">change 24268</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24268"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3e60ebc979010830a5c40112824893a640c58fd4 </div>
<div style="display:none"> Gerrit-Change-Number: 24268 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>