<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24385">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">get_any_lchan(): reduce minor code dup<br><br>Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 4 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/24385/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index c0d9e4d..f3b6c3a 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1643,19 +1643,12 @@</span><br><span>                         ts = &trx->ts[ts_nr];</span><br><span>                         ts_for_n_lchans(lchan, ts, ts->max_primary_lchans) {</span><br><span>                              if (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                   if (bts->chan_alloc_reverse) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                               if (lchan->fi->state == LCHAN_ST_ESTABLISHED)</span><br><span style="color: hsl(120, 100%, 40%);">+                                   if (lchan->fi->state == LCHAN_ST_ESTABLISHED){</span><br><span style="color: hsl(120, 100%, 40%);">+                                          if (!lchan_est || bts->chan_alloc_reverse)</span><br><span>                                                        lchan_est = lchan;</span><br><span style="color: hsl(0, 100%, 40%);">-                                              else</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    lchan_any = lchan;</span><br><span>                                   } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                                                if (lchan->fi->state == LCHAN_ST_ESTABLISHED) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   if (!lchan_est)</span><br><span style="color: hsl(0, 100%, 40%);">-                                                         lchan_est = lchan;</span><br><span style="color: hsl(0, 100%, 40%);">-                                              } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                                                        if (!lchan_any)</span><br><span style="color: hsl(0, 100%, 40%);">-                                                         lchan_any = lchan;</span><br><span style="color: hsl(0, 100%, 40%);">-                                              }</span><br><span style="color: hsl(120, 100%, 40%);">+                                             if (!lchan_any || bts->chan_alloc_reverse)</span><br><span style="color: hsl(120, 100%, 40%);">+                                                 lchan_any = lchan;</span><br><span>                                   }</span><br><span>                            }</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24385">change 24385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24385"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2 </div>
<div style="display:none"> Gerrit-Change-Number: 24385 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>