<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24299">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  neels: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gscon MGCP: properly skip redundant MDCX towards MSC<br><br>So far we were comparing the requested MSC side RTP address+port with<br>the MGW side's address+port, which would practically always fail, and<br>hence we always issued redundant MDCX even if for unchanged MSC side.<br><br>Skip the MDCX if the MSC side remains unchanged.<br>Emit the success event immediately if the MDCX is skipped.<br><br>Depends: Ibb488925827d9dc0ccb1f8d6d84728745d086793 (osmo-mgw/libosmo-mgcp-client)<br>Change-Id: If994ecef9d4269a8120b0575de9b6d0c3be19146<br>---<br>M TODO-RELEASE<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index d0e3ff0..d13cea4 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -10,3 +10,4 @@</span><br><span> libosmocore >1.5.1               needs osmo_bts_features_name(), osmo_bts_features_desc()</span><br><span> libosmogsm    >1.5.1            enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID</span><br><span> libosmogsm    >1.5.1            introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id</span><br><span style="color: hsl(120, 100%, 40%);">+libosmo-mgcp-client >1.8.0  need osmo_mgcpc_ep_ci_get_remote_rtp_info()</span><br><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index f169c32..43804a2 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -600,7 +600,7 @@</span><br><span> </span><br><span>   ci = conn->user_plane.mgw_endpoint_ci_msc;</span><br><span>        if (ci) {</span><br><span style="color: hsl(0, 100%, 40%);">-               const struct mgcp_conn_peer *prev_crcx_info = osmo_mgcpc_ep_ci_get_rtp_info(ci);</span><br><span style="color: hsl(120, 100%, 40%);">+              const struct mgcp_conn_peer *prev_crcx_info = osmo_mgcpc_ep_ci_get_remote_rtp_info(ci);</span><br><span> </span><br><span>          if (!conn->user_plane.mgw_endpoint) {</span><br><span>                     LOGPFSML(conn->fi, LOGL_ERROR, "Internal error: conn has a CI but no endpoint\n");</span><br><span>@@ -618,6 +618,8 @@</span><br><span>                        LOGPFSML(conn->fi, LOGL_DEBUG,</span><br><span>                             "MSC side MGW endpoint ci is already configured to %s\n",</span><br><span>                                  osmo_mgcpc_ep_ci_name(ci));</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* Immediately dispatch the success event */</span><br><span style="color: hsl(120, 100%, 40%);">+                  osmo_fsm_inst_dispatch(notify, event_success, notify_data);</span><br><span>                  return true;</span><br><span>                 }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24299">change 24299</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24299"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If994ecef9d4269a8120b0575de9b6d0c3be19146 </div>
<div style="display:none"> Gerrit-Change-Number: 24299 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>