<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/24320">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess: do not block ipaccess_line_update on failure<br><br>The function ipaccess_line_update (called when the API user calls<br>e1inp_line_update and the line is of type ipaccess) internally sets<br>the line_already_initialized regardless whether the initalization is<br>successful or not.<br><br>This also means that if the initalization fails the API user is unable<br>to retry the initalition with corrected line options.<br><br>Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d<br>Related: SYS#4971<br>---<br>M src/input/ipaccess.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index e876790..a584e0d 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -1025,8 +1025,6 @@</span><br><span>   if (il->line_already_initialized)</span><br><span>                 return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   il->line_already_initialized = true;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      switch(line->ops->cfg.ipa.role) {</span><br><span>      case E1INP_LINE_R_BSC: {</span><br><span>             struct ipa_server_link *oml_link, *rsl_link;</span><br><span>@@ -1112,6 +1110,8 @@</span><br><span>         default:</span><br><span>             break;</span><br><span>       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   il->line_already_initialized = true;</span><br><span>      return ret;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/24320">change 24320</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/24320"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d </div>
<div style="display:none"> Gerrit-Change-Number: 24320 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>