<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/24332">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipa: do not open socket in nonblocking mode<br><br>The function ipa_client_conn_open opens an osmo-socket using<br>osmo_sock_init2 and sets the OSMO_SOCK_F_NONBLOCK. This makes error<br>detection (e.g. host is unreachable) difficult because the connect call<br>will return with -EINPROGRESS, which is not handled as an error, so<br>opening a socket to any random ip-address will be successful.<br><br>Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be<br>Related: SYS#4971<br>---<br>M src/input/ipa.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/32/24332/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipa.c b/src/input/ipa.c</span><br><span>index c121987..6bc3f4a 100644</span><br><span>--- a/src/input/ipa.c</span><br><span>+++ b/src/input/ipa.c</span><br><span>@@ -224,7 +224,7 @@</span><br><span>     ret = osmo_sock_init2(AF_INET, SOCK_STREAM, IPPROTO_TCP,</span><br><span>                          link->local_addr, link->local_port,</span><br><span>                            link->addr, link->port,</span><br><span style="color: hsl(0, 100%, 40%);">-                           OSMO_SOCK_F_BIND|OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_NONBLOCK|</span><br><span style="color: hsl(120, 100%, 40%);">+                            OSMO_SOCK_F_BIND|OSMO_SOCK_F_CONNECT|</span><br><span>                        OSMO_SOCK_F_DSCP(link->dscp) | OSMO_SOCK_F_PRIO(link->priority));</span><br><span>         if (ret < 0)</span><br><span>              return ret;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/24332">change 24332</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/24332"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be </div>
<div style="display:none"> Gerrit-Change-Number: 24332 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>