<p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py">File src/osmo_gsm_tester/obj/enb_srs.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@398">Patch Set #1, Line 398:</a> <code style="font-family:monospace,monospace">                path = self._conf.get('library_path', None)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So this is some library in some rando path in the system? why is it not in the trial? I think all this deserves proper description of the setup and why is it done this way.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@401">Patch Set #1, Line 401:</a> <code style="font-family:monospace,monospace">                    return </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@404">Patch Set #1, Line 404:</a> <code style="font-family:monospace,monospace">                self.rem_host.change_elf_force_rpath(remote_binary, path)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why is the usual change_elf_rpath() working here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281">change 24281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd7689a41a1c5fe8e4c427f3b9bc69b3f2b0f8ac </div>
<div style="display:none"> Gerrit-Change-Number: 24281 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alejandro Leal <alejandro.leal@srs.io> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 May 2021 12:53:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>