<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24301">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: rename lchan_activate_mode to lchan_activate_for<br><br>In subsequent patches, I will add enum lchan_modify_for and enum<br>assignment_for, I prefer to have similar lchan_activate_for naming.<br><br>Change-Id: Ia4420fcd1234dbee92e768e5a32eab13fba29ea9<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/lchan_fsm.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/24301/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index e3101ff..bd83ea0 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -558,7 +558,7 @@</span><br><span>  */</span><br><span> #define ts_for_each_potential_lchan(lchan, ts) ts_as_pchan_for_each_lchan(lchan, ts, (ts)->pchan_on_init)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-enum lchan_activate_mode {</span><br><span style="color: hsl(120, 100%, 40%);">+enum lchan_activate_for {</span><br><span>         ACTIVATE_FOR_NONE,</span><br><span>   ACTIVATE_FOR_MS_CHANNEL_REQUEST,</span><br><span>     ACTIVATE_FOR_ASSIGNMENT,</span><br><span>@@ -567,11 +567,11 @@</span><br><span> };</span><br><span> </span><br><span> extern const struct value_string lchan_activate_mode_names[];</span><br><span style="color: hsl(0, 100%, 40%);">-static inline const char *lchan_activate_mode_name(enum lchan_activate_mode activ_for)</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *lchan_activate_mode_name(enum lchan_activate_for activ_for)</span><br><span> { return get_value_string(lchan_activate_mode_names, activ_for); }</span><br><span> </span><br><span> struct lchan_activate_info {</span><br><span style="color: hsl(0, 100%, 40%);">-      enum lchan_activate_mode activ_for;</span><br><span style="color: hsl(120, 100%, 40%);">+   enum lchan_activate_for activ_for;</span><br><span>   struct gsm_subscriber_connection *for_conn;</span><br><span>  /* This always is for a specific lchan, so its lchan->type indicates full or half rate.</span><br><span>    * When a dyn TS was selected, the lchan->type has been set to the desired rate. */</span><br><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 8527d38..83524e0 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -70,7 +70,7 @@</span><br><span> #define lchan_on_activation_failure(lchan, for_conn, activ_for) \</span><br><span>         _lchan_on_activation_failure(lchan, for_conn, activ_for, \</span><br><span>                                __FILE__, __LINE__)</span><br><span style="color: hsl(0, 100%, 40%);">-static void _lchan_on_activation_failure(struct gsm_lchan *lchan, enum lchan_activate_mode activ_for,</span><br><span style="color: hsl(120, 100%, 40%);">+static void _lchan_on_activation_failure(struct gsm_lchan *lchan, enum lchan_activate_for activ_for,</span><br><span>                                   struct gsm_subscriber_connection *for_conn,</span><br><span>                                          const char *file, int line)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24301">change 24301</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24301"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia4420fcd1234dbee92e768e5a32eab13fba29ea9 </div>
<div style="display:none"> Gerrit-Change-Number: 24301 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>